Ignore case on FormatDateTime_WithMilliseconds_NewZealandCulture #9316
Merged
danmoseley merged 1 commit intodotnet:mainfrom May 15, 2025
Merged
Ignore case on FormatDateTime_WithMilliseconds_NewZealandCulture #9316danmoseley merged 1 commit intodotnet:mainfrom
danmoseley merged 1 commit intodotnet:mainfrom
Conversation
…to macos formatting difference
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the FormatDateTime test for New Zealand culture to handle macOS’s use of uppercase AM/PM by adding case-insensitive comparison.
- Updated the Assert.Equal call to include ignoreCase:true.
- Removed an ActiveIssue attribute that is no longer needed due to the improved date format handling.
Member
|
Why does MacOS use uppercase? NZ culture is to lower case the am/pm. |
Member
Author
Great question. No clue. However, to verify this on a mac terminal: Why has it failed just now? I don't see a failure? |
JamesNK
approved these changes
May 14, 2025
Member
|
Ok. I don't think it's important enough to research closely. Most likely there is something weird about MacOS culture settings. |
Member
|
It wasn't previously run on Mac most likely. @radical just added Mac coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
macOS uses uppercase for AM/PM in this culture.
Fixes #9151
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate