Don't throw from component telemetry context dispose if not initialized#9306
Merged
danmoseley merged 2 commits intomainfrom May 14, 2025
Merged
Don't throw from component telemetry context dispose if not initialized#9306danmoseley merged 2 commits intomainfrom
danmoseley merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that disposing a ComponentTelemetryContext without prior initialization does not throw an exception. The changes include:
- Updated test cases to cover telemetry enabled, telemetry disabled, and disposal without initialization scenarios.
- Modified ComponentTelemetryContext to use a safe-call operator in Dispose, preventing exceptions when the telemetry service is unassigned.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Aspire.Dashboard.Tests/Telemetry/ComponentTelemetryContextTests.cs | Added test coverage for disposal behavior with and without telemetry enabled. |
| src/Aspire.Dashboard/Components/Pages/ComponentTelemetryContext.cs | Altered property access and disposal logic to safely handle uninitialized telemetry service. |
davidfowl
approved these changes
May 14, 2025
danmoseley
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that
ComponentTelemetryContext.Dispose()would throw if called without the context being initialized. This could happen if there is an error in a component before initialization and then the context is dispose with the component.It's a bug but not a critical one. Requires other things to go wrong first.
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate