Skip to content

Enable stable branding for release 9.3#9289

Merged
joperezr merged 3 commits intodotnet:release/9.3from
joperezr:StableBranding
May 13, 2025
Merged

Enable stable branding for release 9.3#9289
joperezr merged 3 commits intodotnet:release/9.3from
joperezr:StableBranding

Conversation

@joperezr
Copy link
Member

Enabling stable branding for release branch.

cc: @wtgodbe

Copilot AI review requested due to automatic review settings May 13, 2025 19:23
@joperezr joperezr requested review from eerhardt and radical as code owners May 13, 2025 19:23
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 13, 2025
-->

<Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="$(PackageVersion)" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" />
<Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="9.3.0" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we do this hardcoding every time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love for that not to be the case but we haven't made the work to fix it. Main issue is that PackageVersion can't be used as that is a variable that changes depending on the project you are building, so when you are emitting a reference (like in this case or in the Directory.Packages.Helix.props) to a different package getting built, you don't want to use PackageVersion (as that is the package version of the project getting built) and instead you want to have a way to call a target into that reference to know whether or not that specific reference should be stable or not.

This is not super trivial and we haven't been able to prioritize it, so for now, we have to hard code each time we stabilize, but I'd love to not have to do this in the future :)

<PackageVersion Include="Aspire.Elastic.Clients.Elasticsearch" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Azure.Data.Tables" Version="9.3.0" />
<PackageVersion Include="Aspire.Azure.Messaging.EventHubs" Version="9.3.0" />
<PackageVersion Include="Aspire.Azure.Messaging.ServiceBus" Version="9.3.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same q here

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enables stable branding by pinning packages and SDK imports to version 9.3.0 and turning on the stabilization flag.

  • Pins numerous Aspire package references in test projects to 9.3.0
  • Updates Aspire.AppHost.Sdk imports to version 9.3.0 in test targets
  • Sets <StabilizePackageVersion> to true in eng/Versions.props

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/Shared/RepoTesting/Directory.Packages.Helix.props Pinned multiple Aspire package versions from $(PackageVersion) to 9.3.0 in test manifests.
tests/Shared/RepoTesting/Aspire.RepoTesting.targets Updated Import statements for Aspire.AppHost.Sdk to use version 9.3.0.
eng/Versions.props Enabled stable package versioning by changing <StabilizePackageVersion> default to true.
Comments suppressed due to low confidence (1)

tests/Shared/RepoTesting/Directory.Packages.Helix.props:25

  • This entry still uses $(PackageVersion) while its neighbors are pinned to 9.3.0. Consider updating it to 9.3.0 or parameterizing all versions consistently.
<PackageVersion Include="Aspire.Hosting.Azure.ContainerRegistry" Version="$(PackageVersion)" />

Comment on lines 4 to +29
<ItemGroup Label="Aspire packages">
<PackageVersion Include="Aspire.Azure.AI.OpenAI" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Azure.Data.Tables" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Azure.Messaging.EventHubs" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Azure.Messaging.ServiceBus" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Azure.Messaging.WebPubSub" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Azure.Search.Documents" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Azure.Security.KeyVault" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Azure.Storage.Blobs" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Azure.Storage.Queues" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Confluent.Kafka" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Elastic.Clients.Elasticsearch" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Azure.Data.Tables" Version="9.3.0" />
<PackageVersion Include="Aspire.Azure.Messaging.EventHubs" Version="9.3.0" />
<PackageVersion Include="Aspire.Azure.Messaging.ServiceBus" Version="9.3.0" />
<PackageVersion Include="Aspire.Azure.Messaging.WebPubSub" Version="9.3.0" />
<PackageVersion Include="Aspire.Azure.Search.Documents" Version="9.3.0" />
<PackageVersion Include="Aspire.Azure.Security.KeyVault" Version="9.3.0" />
<PackageVersion Include="Aspire.Azure.Storage.Blobs" Version="9.3.0" />
<PackageVersion Include="Aspire.Azure.Storage.Queues" Version="9.3.0" />
<PackageVersion Include="Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL" Version="9.3.0" />
<PackageVersion Include="Aspire.Confluent.Kafka" Version="9.3.0" />
<PackageVersion Include="Aspire.Elastic.Clients.Elasticsearch" Version="9.3.0" />

<PackageVersion Include="Aspire.Hosting" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.AppHost" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.AppConfiguration" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.ApplicationInsights" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.CognitiveServices" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.CosmosDB" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting" Version="9.3.0" />
<PackageVersion Include="Aspire.Hosting.AppHost" Version="9.3.0" />
<PackageVersion Include="Aspire.Hosting.Azure" Version="9.3.0" />
<PackageVersion Include="Aspire.Hosting.Azure.AppConfiguration" Version="9.3.0" />
<PackageVersion Include="Aspire.Hosting.Azure.ApplicationInsights" Version="9.3.0" />
<PackageVersion Include="Aspire.Hosting.Azure.CognitiveServices" Version="9.3.0" />
<PackageVersion Include="Aspire.Hosting.Azure.CosmosDB" Version="9.3.0" />
<PackageVersion Include="Aspire.Hosting.Azure.ContainerRegistry" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.EventHubs" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.EventHubs" Version="9.3.0" />
<PackageVersion Include="Aspire.Hosting.Azure.Functions" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.KeyVault" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.OperationalInsights" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.PostgreSQL" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.Redis" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.Search" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.ServiceBus" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.SignalR" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.Sql" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.Storage" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.WebPubSub" Version="$(PackageVersion)" />
<PackageVersion Include="Aspire.Hosting.Azure.KeyVault" Version="9.3.0" />
<PackageVersion Include="Aspire.Hosting.Azure.OperationalInsights" Version="9.3.0" />
Copy link

Copilot AI May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The version literal 9.3.0 is duplicated across many lines. Extract this into a shared MSBuild property to reduce repetition and simplify future updates.

Copilot uses AI. Check for mistakes.
Comment on lines +36 to 38
<Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="9.3.0" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" />

<PropertyGroup>
Copy link

Copilot AI May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Hardcoding the SDK version can lead to more churn each release. Consider referencing a centralized version property (e.g., $(AspireSdkVersion)) to DRY up the files.

Suggested change
<Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="9.3.0" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" />
<PropertyGroup>
<Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="$(AspireSdkVersion)" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" />
<PropertyGroup>
<AspireSdkVersion>9.3.0</AspireSdkVersion>

Copilot uses AI. Check for mistakes.
@@ -3,88 +3,88 @@

<ItemGroup Label="Aspire packages">
<PackageVersion Include="Aspire.Azure.AI.OpenAI" Version="$(PackageVersion)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no update here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this package is not going to get stable yet so no need to stabilize the reference:

<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>

@radical
Copy link
Member

radical commented May 13, 2025

Can we validate this with Azdo public+internal pipeline runs too?

@joperezr joperezr merged commit 69d4e75 into dotnet:release/9.3 May 13, 2025
344 of 346 checks passed
@joperezr
Copy link
Member Author

Can we validate this with Azdo public+internal pipeline runs too?

Oh, sorry just saw this and I merged already. Will keep an eye to internal builds and fix anything that is needed

@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants