Enable stable branding for release 9.3#9289
Conversation
| --> | ||
|
|
||
| <Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="$(PackageVersion)" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" /> | ||
| <Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="9.3.0" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" /> |
There was a problem hiding this comment.
Do we do this hardcoding every time?
There was a problem hiding this comment.
I'd love for that not to be the case but we haven't made the work to fix it. Main issue is that PackageVersion can't be used as that is a variable that changes depending on the project you are building, so when you are emitting a reference (like in this case or in the Directory.Packages.Helix.props) to a different package getting built, you don't want to use PackageVersion (as that is the package version of the project getting built) and instead you want to have a way to call a target into that reference to know whether or not that specific reference should be stable or not.
This is not super trivial and we haven't been able to prioritize it, so for now, we have to hard code each time we stabilize, but I'd love to not have to do this in the future :)
| <PackageVersion Include="Aspire.Elastic.Clients.Elasticsearch" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Azure.Data.Tables" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Messaging.EventHubs" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Messaging.ServiceBus" Version="9.3.0" /> |
There was a problem hiding this comment.
Pull Request Overview
Enables stable branding by pinning packages and SDK imports to version 9.3.0 and turning on the stabilization flag.
- Pins numerous Aspire package references in test projects to 9.3.0
- Updates Aspire.AppHost.Sdk imports to version 9.3.0 in test targets
- Sets
<StabilizePackageVersion>totrueineng/Versions.props
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Shared/RepoTesting/Directory.Packages.Helix.props | Pinned multiple Aspire package versions from $(PackageVersion) to 9.3.0 in test manifests. |
| tests/Shared/RepoTesting/Aspire.RepoTesting.targets | Updated Import statements for Aspire.AppHost.Sdk to use version 9.3.0. |
| eng/Versions.props | Enabled stable package versioning by changing <StabilizePackageVersion> default to true. |
Comments suppressed due to low confidence (1)
tests/Shared/RepoTesting/Directory.Packages.Helix.props:25
- This entry still uses $(PackageVersion) while its neighbors are pinned to 9.3.0. Consider updating it to 9.3.0 or parameterizing all versions consistently.
<PackageVersion Include="Aspire.Hosting.Azure.ContainerRegistry" Version="$(PackageVersion)" />
| <ItemGroup Label="Aspire packages"> | ||
| <PackageVersion Include="Aspire.Azure.AI.OpenAI" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Azure.Data.Tables" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Azure.Messaging.EventHubs" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Azure.Messaging.ServiceBus" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Azure.Messaging.WebPubSub" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Azure.Search.Documents" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Azure.Security.KeyVault" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Azure.Storage.Blobs" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Azure.Storage.Queues" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Confluent.Kafka" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Elastic.Clients.Elasticsearch" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Azure.Data.Tables" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Messaging.EventHubs" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Messaging.ServiceBus" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Messaging.WebPubSub" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Search.Documents" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Security.KeyVault" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Storage.Blobs" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Storage.Queues" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Confluent.Kafka" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Elastic.Clients.Elasticsearch" Version="9.3.0" /> | ||
|
|
||
| <PackageVersion Include="Aspire.Hosting" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.AppHost" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.AppConfiguration" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.ApplicationInsights" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.CognitiveServices" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.CosmosDB" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.AppHost" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.AppConfiguration" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.ApplicationInsights" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.CognitiveServices" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.CosmosDB" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.ContainerRegistry" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.EventHubs" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.EventHubs" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.Functions" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.KeyVault" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.OperationalInsights" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.PostgreSQL" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.Redis" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.Search" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.ServiceBus" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.SignalR" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.Sql" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.Storage" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.WebPubSub" Version="$(PackageVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.KeyVault" Version="9.3.0" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.OperationalInsights" Version="9.3.0" /> |
There was a problem hiding this comment.
[nitpick] The version literal 9.3.0 is duplicated across many lines. Extract this into a shared MSBuild property to reduce repetition and simplify future updates.
| <Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="9.3.0" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" /> | ||
|
|
||
| <PropertyGroup> |
There was a problem hiding this comment.
[nitpick] Hardcoding the SDK version can lead to more churn each release. Consider referencing a centralized version property (e.g., $(AspireSdkVersion)) to DRY up the files.
| <Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="9.3.0" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" /> | |
| <PropertyGroup> | |
| <Import Project="Sdk.props" Sdk="Aspire.AppHost.Sdk" Version="$(AspireSdkVersion)" Condition="'$(IsAspireHost)' == 'true' and '$(RepoRoot)' == '' and '$(TestsRunningOutsideOfRepo)' == 'true'" /> | |
| <PropertyGroup> | |
| <AspireSdkVersion>9.3.0</AspireSdkVersion> |
| @@ -3,88 +3,88 @@ | |||
|
|
|||
| <ItemGroup Label="Aspire packages"> | |||
| <PackageVersion Include="Aspire.Azure.AI.OpenAI" Version="$(PackageVersion)" /> | |||
There was a problem hiding this comment.
Because this package is not going to get stable yet so no need to stabilize the reference:
src/Aspire.Hosting.Azure.AppContainers/Aspire.Hosting.Azure.AppContainers.csproj
Show resolved
Hide resolved
|
Can we validate this with Azdo public+internal pipeline runs too? |
Oh, sorry just saw this and I merged already. Will keep an eye to internal builds and fix anything that is needed |
Enabling stable branding for release branch.
cc: @wtgodbe