[release/9.3] Respond to API Review feedback#9285
Merged
joperezr merged 5 commits intodotnet:release/9.3from May 13, 2025
Merged
[release/9.3] Respond to API Review feedback#9285joperezr merged 5 commits intodotnet:release/9.3from
joperezr merged 5 commits intodotnet:release/9.3from
Conversation
…ainerRegistry is experimental.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses API review feedback by refining the public API surface and consolidating namespaces while removing unused or redundant references.
- Removed obsolete using directives in test files.
- Added or updated Experimental attributes and suppression pragmas in production code.
- Updated access modifiers and namespaces to streamline the API design.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Hosting.Azure.Tests/AzureContainerRegistryTests.cs | Removed unused using directive. |
| tests/Aspire.Hosting.Azure.Tests/AzureContainerAppsTests.cs | Removed unused using directive. |
| tests/Aspire.Hosting.Azure.Tests/AzureAppServiceTests.cs | Removed unused using directive. |
| src/Aspire.Hosting/ResourceBuilderExtensions.cs | Added Experimental attribute for publishing callback. |
| src/Aspire.Hosting/Publishing/PublishingContext.cs | Added using statement and Experimental attribute. |
| src/Aspire.Hosting/Publishing/Publisher.cs | Added pragma suppression for Experimental API warning. |
| src/Aspire.Hosting/PublisherDistributedApplicationBuilderExtensions.cs | Changed API access from public to internal and removed the Experimental attribute. |
| src/Aspire.Hosting/CompatibilitySuppressions.xml | Updated suppressions for removed experimental publishers. |
| src/Aspire.Hosting/ApplicationModel/PublishingCallbackAnnotation.cs | Added using statement and Experimental attribute. |
| src/Aspire.Hosting/ApplicationModel/ContainerRegistryReferenceAnnotation.cs | Added using statement and Experimental attribute. |
| src/Aspire.Hosting.Kubernetes/KubernetesEnvironmentResource.cs | Added pragma suppression for Experimental API warning. |
| src/Aspire.Hosting.Docker/DockerComposeEnvironmentResource.cs | Added pragma suppression for Experimental API warning within publish method. |
| src/Aspire.Hosting.Azure/AzurePublishingContext.cs | Converted a public field to an immutable property. |
| src/Aspire.Hosting.Azure/AzureEnvironmentResourceExtensions.cs | Updated using directives and namespace declaration. |
| src/Aspire.Hosting.Azure.Storage/AzureBlobStorageContainerResource.cs | Updated namespace from Aspire.Hosting to Aspire.Hosting.Azure. |
| src/Aspire.Hosting.Azure.ContainerRegistry/AzureContainerRegistryResource.cs | Normalized pragma format and updated namespace. |
| src/Aspire.Hosting.Azure.ContainerRegistry/AzureContainerRegistryExtensions.cs | Removed unused using directive. |
| src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentResource.cs | Updated namespace from Azure.AppService to Azure. |
| src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentExtensions.cs | Introduced pragma suppression around annotation use. |
| src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppExtensions.cs | Introduced pragma suppression around annotation use. |
Member
|
Can you also make the publishing apis experimental (annotation and WithPublishingCallback?) |
Member
Author
I am making them experimental: aspire/src/Aspire.Hosting/Publishing/PublishingContext.cs Lines 18 to 19 in f092e67 aspire/src/Aspire.Hosting/ResourceBuilderExtensions.cs Lines 294 to 295 in f092e67 |
davidfowl
approved these changes
May 13, 2025
joperezr
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer Impact
Adjusting our public APIs before release, so we don't have to make breaking changes, or live with unwanted API shape.
See API review comments on #8736.
Testing
Unit tests.
Risk
Low since these APIs are either experiemental or haven't shipped yet.
Regression?
No