Changing default SKU for App Service Plan to P0V3#9280
Changing default SKU for App Service Plan to P0V3#9280davidfowl merged 5 commits intodotnet:mainfrom
Conversation
src/Aspire.Hosting.Azure.AppService/AzureAppServiceWebsiteContext.cs
Outdated
Show resolved
Hide resolved
| SiteConfig = new SiteConfigProperties() | ||
| { | ||
| LinuxFxVersion = BicepFunction.Interpolate($"DOCKER|{containerImage}"), | ||
| LinuxFxVersion = "SITECONTAINERS", |
There was a problem hiding this comment.
Confused by this change. Why do we need sidecars? Or is this just the new way of using containers?
There was a problem hiding this comment.
yes this is what we want to do going fwd instead of overloading the linuxFX version. There is no sidecar being configured here
There was a problem hiding this comment.
Why is the port hardcoded to 8080?
There was a problem hiding this comment.
Removed setting the port as it is inferred by the platform. Validated with the changes in fork code
There was a problem hiding this comment.
Doesn't this need to be set to the internal port of the http endpoint?
There was a problem hiding this comment.
When TargetPort is not specified, our container orchestrator can infer the exposed PORT in the container image and use it for serving the http traffic. So, explicitly mentioning TargetPort is not required.
@dotnet-policy-service agree company="Microsoft" |
| Name = "P0V3", | ||
| Tier = "Premium" |
There was a problem hiding this comment.
I'm having second thoughts about this one.
|
/backport to release/9.3 |
|
Started backporting to release/9.3: https://github.com/dotnet/aspire/actions/runs/15047478952 |
Description
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate