Fixed endpoint mapping in compose resources#9224
Merged
Conversation
- Process arguments and env variables in the publish phase. This delays the resolution of endpoints until they are all processed. - Also handled bait and switch resources (executable -> container)
davidfowl
commented
May 10, 2025
|
|
||
| namespace Aspire.Hosting.Docker; | ||
|
|
||
| internal sealed class ResourceComparer : IEqualityComparer<IResource> |
Member
Author
There was a problem hiding this comment.
This made me realize we have the same problem with the ACA logic, putting up a fix for that now.
Member
Author
There was a problem hiding this comment.
mitchdenny
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8674
Checklist