Skip to content

Add new 3rd party dependencies to Signing.props to fix official build#8222

Merged
joperezr merged 1 commit intodotnet:mainfrom
joperezr:FixSigningProps
Mar 21, 2025
Merged

Add new 3rd party dependencies to Signing.props to fix official build#8222
joperezr merged 1 commit intodotnet:mainfrom
joperezr:FixSigningProps

Conversation

@joperezr
Copy link
Member

@joperezr joperezr commented Mar 20, 2025

Description

Fixes official build by adding recently added 3rd party dependencies to signing.props. cc: @mitchdenny @maddymontaquila @radical

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

@joperezr joperezr requested review from Copilot and radical March 20, 2025 21:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • eng/Signing.props: Language not supported

@github-actions github-actions bot added the area-engineering-systems infrastructure helix infra engineering repo stuff label Mar 20, 2025
@radical
Copy link
Member

radical commented Mar 20, 2025

We should do internal pipeline build of this too.

@RussKie
Copy link
Contributor

RussKie commented Mar 20, 2025

@joperezr have you done an internal build to validate this is the exhaustive list?

@joperezr
Copy link
Member Author

@joperezr have you done an internal build to validate this is the exhaustive list?

I did, build is signed and green so I'll go ahead and merge this.

@joperezr joperezr enabled auto-merge (squash) March 21, 2025 16:16
@joperezr joperezr merged commit fca6ddb into dotnet:main Mar 21, 2025
168 checks passed
@joperezr joperezr deleted the FixSigningProps branch April 1, 2025 17:43
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants