[Testing] Remove ResourceNameSuffix randomization#7378
Merged
ReubenBond merged 1 commit intomainfrom Feb 3, 2025
Merged
Conversation
caa1550 to
7e48482
Compare
karolz-ms
approved these changes
Feb 3, 2025
ResourceNameSuffix randomizationResourceNameSuffix randomization
Member
|
Looked into the test failure, looked unrelated. We should use the Build Analysis tab to file the issue and just merge next time 😄 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aspire.Hosting.Testing currently adds a random suffix to resource names to reduce the chance of clashes when running tests in parallel. This is no longer necessary, as @karolz-ms points out, since DCP includes its own distinguisher. This PR disables resource name suffix randomization.
Users can still randomize resource name suffixes themselves by passing a random suffix to
DistributedApplicationTestingBuilderlike so:For context, see: #6891 (comment)
Fixes #6891
Fixes #6850
I verified that this addresses the above issue by running the Aspire.Hosting.Testing.Tests suite locally. I don't feel we need a specific unit test for this behavior at this time.
Before this change:
After this change:
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):