Skip to content

Replace health check publisher and scheduler with ResourceHealthCheckService and introduce ResourceReadyEvent.#5870

Merged
mitchdenny merged 24 commits intomainfrom
mitchdenny/resource-healthy-event
Sep 30, 2024
Merged

Replace health check publisher and scheduler with ResourceHealthCheckService and introduce ResourceReadyEvent.#5870
mitchdenny merged 24 commits intomainfrom
mitchdenny/resource-healthy-event

Conversation

@mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Sep 24, 2024 •
edited
Loading

Description

This PR removes the health check publisher and scheduler and combines it into a single ResourceHealthCheckService which runs in the background doing health checks on a per resource basis.

Fixes #5602
Fixes #5638
Fixes #5871
Fixes #5943

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No (existing tests provide coverage - internal mechanism now relies on this event)
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@mitchdenny mitchdenny self-assigned this Sep 24, 2024
@mitchdenny mitchdenny added this to the 9.0 milestone Sep 24, 2024
@mitchdenny mitchdenny added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Sep 24, 2024
@mitchdenny
Copy link
Member Author

mitchdenny commented Sep 24, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 24, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Sep 24, 2024
Open
3 tasks
@mitchdenny mitchdenny force-pushed the mitchdenny/resource-healthy-event branch from 6393f39 to 6a69d3a Compare September 25, 2024 05:49
@build-analysis build-analysis bot mentioned this pull request Sep 25, 2024
Closed
3 tasks
@mitchdenny
Copy link
Member Author

mitchdenny commented Sep 25, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 25, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny mentioned this pull request Sep 25, 2024
Closed
@mitchdenny
Copy link
Member Author

mitchdenny commented Sep 25, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 25, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny mentioned this pull request Sep 26, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Sep 26, 2024
Closed
@mitchdenny mitchdenny changed the title ResourceHealthyEvent and suppressing health checks that have become healthy. Replace health check publisher and scheduler with ResourceHealthCheckService and introduce ResourceReadyEvent. Sep 29, 2024
davidfowl
davidfowl reviewed Sep 29, 2024
View reviewed changes
davidfowl
davidfowl reviewed Sep 29, 2024
View reviewed changes
davidfowl
davidfowl reviewed Sep 29, 2024
View reviewed changes
davidfowl
davidfowl reviewed Sep 29, 2024
View reviewed changes
davidfowl
davidfowl reviewed Sep 29, 2024
View reviewed changes
davidfowl
davidfowl reviewed Sep 29, 2024
View reviewed changes
davidfowl
davidfowl reviewed Sep 29, 2024
View reviewed changes
@mitchdenny mitchdenny marked this pull request as ready for review September 30, 2024 03:05
davidfowl
davidfowl reviewed Sep 30, 2024
View reviewed changes
davidfowl
davidfowl reviewed Sep 30, 2024
View reviewed changes
mitchdenny and others added 2 commits September 30, 2024 14:18
@mitchdenny @davidfowl
Update src/Aspire.Hosting/Health/ResourceHealthCheckService.cs
dc0b426 
Co-authored-by: David Fowler <davidfowl@gmail.com>
@mitchdenny @davidfowl
Update src/Aspire.Hosting/Health/ResourceHealthCheckService.cs
b46c2f7 
Co-authored-by: David Fowler <davidfowl@gmail.com>
davidfowl
davidfowl approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up: Make ResourceHealthCheckService more testable using the time provider and add more logs.

@mitchdenny mitchdenny mentioned this pull request Sep 30, 2024
Closed
@mitchdenny mitchdenny merged commit 94008ce into main Sep 30, 2024
@mitchdenny mitchdenny deleted the mitchdenny/resource-healthy-event branch September 30, 2024 07:30
This was referenced Sep 30, 2024
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidfowl davidfowl davidfowl approved these changes

Assignees

@mitchdenny mitchdenny

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Milestone

9.0

2 participants

@mitchdenny @davidfowl