reenable tests to start debugging in the pipeline (they run fine local…#4618
Merged
mitchdenny merged 52 commits intomainfrom Jun 25, 2024
Merged
reenable tests to start debugging in the pipeline (they run fine local…#4618mitchdenny merged 52 commits intomainfrom
mitchdenny merged 52 commits intomainfrom
Conversation
- Add ResourceNotificationService.WaitForResource
…ice.cs Co-authored-by: Ankit Jain <radical@gmail.com>
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
Member
|
#4444 is now merged. Can this PR be cleaned up to just contain the reenable test changes? |
Member
done |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ot starting cleanly.
…into mitchdenny/fix-4613
Open
3 tasks
Member
Author
|
@radical this is ready to go in. There is some flakiness in an unrelated test case which I've added a WaitForResource(...) on so we can get a clearer picture of root cause. |
radical
approved these changes
Jun 24, 2024
Member
|
Thank you for fixing this, @mitchdenny !! |
eerhardt
approved these changes
Jun 24, 2024
| using var app = builder.Build(); | ||
| await app.StartAsync(); | ||
|
|
||
| var runningCts = new CancellationTokenSource(TimeSpan.FromSeconds(180)); |
Member
There was a problem hiding this comment.
Is it easier to say 3 minutes? Repeated elswhere.
Member
|
When we merge this, please make sure the 50 commits on this PR don't show up in the merge/squash commit message. |
radical
reviewed
Jun 24, 2024
| @@ -42,6 +42,10 @@ public void CanGetResources() | |||
| [RequiresDocker] | |||
| public async Task HttpClientGetTest() | |||
Member
There was a problem hiding this comment.
This test is still failing!
System.Net.Http.HttpRequestException : Connection refused (localhost:5150)
---- System.Net.Sockets.SocketException : Connection refused
at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.<SendCoreAsync>g__Core|5_0(HttpRequestMessage request, Boolean useAsync, CancellationToken cancellationToken)
at Microsoft.Extensions.Http.Resilience.ResilienceHandler.<>c.<<SendAsync>b__3_0>d.MoveNext()
--- End of stack trace from previous location ---
at Polly.Outcome`1.ThrowIfException()
at Microsoft.Extensions.Http.Resilience.ResilienceHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.<SendCoreAsync>g__Core|5_0(HttpRequestMessage request, Boolean useAsync, CancellationToken cancellationToken)
at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
at System.Net.Http.Json.HttpClientJsonExtensions.<FromJsonAsyncCore>g__Core|12_0[TValue,TJsonOptions](HttpClient client, Task`1 responseTask, Boolean usingResponseHeadersRead, CancellationTokenSource linkedCTS, Func`4 deserializeMethod, TJsonOptions jsonOptions, CancellationToken cancellationToken)
at Aspire.Hosting.Testing.Tests.TestingFactoryTests.HttpClientGetTest() in /_/tests/Aspire.Hosting.Testing.Tests/TestingFactoryTests.cs:line 50
--- End of stack trace from previous location ---
----- Inner Stack Trace -----
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|285_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
Member
There was a problem hiding this comment.
I noticed that if starting the apphost fails for some reason like dev-certs are not installed (from the log):
mywebapp1[0] 1: 2024-06-25T00:36:33.7093120 �[41m�[30mfail�[39m�[22m�[49m: Microsoft.Extensions.Hosting.Internal.Host[11]
mywebapp1[0] 2: Hosting failed to start
mywebapp1[0] 3: System.InvalidOperationException: Unable to configure HTTPS endpoint. No server certificate was specified, and the default developer certificate could not be found or is out of date.
mywebapp1[0] 4: To generate a developer certificate run 'dotnet dev-certs https'. To trust the certificate (Windows and macOS only) run 'dotnet dev-certs https --trust'.
mywebapp1[0] 5: For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?linkid=848054.
mywebapp1[0] 6: at Microsoft.AspNetCore.Hosting.ListenOptionsHttpsExtensions.UseHttps(ListenOptions listenOptions, Action`1 configureOptions)
mywebapp1[0] 7: at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.AddressesStrategy.BindAsync(AddressBindContext context, CancellationToken cancellationToken)
mywebapp1[0] 8: at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindAsync(ListenOptions[] listenOptions, AddressBindContext context, Func`2 useHttps, CancellationToken cancellationToken)
mywebapp1[0] 9: at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.BindAsync(CancellationToken cancellationToken)
mywebapp1[0] 10: at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServerImpl.StartAsync[TContext](IHttpApplication`1 application, CancellationToken cancellationToken)
mywebapp1[0] 11: at Microsoft.AspNetCore.Hosting.GenericWebHostService.StartAsync(CancellationToken cancellationToken)
mywebapp1[0] 12: at Microsoft.Extensions.Hosting.Internal.Host.<StartAsync>b__15_1(IHostedService service, CancellationToken token)
.. that doesn't prevent the test from running. And these two lines in the test run successfully:
var rns = _app.Services.GetRequiredService<ResourceNotificationService>();
await rns.WaitForResourceAsync("mywebapp1").WaitAsync(TimeSpan.FromSeconds(60));
var httpClient = _app.CreateHttpClientWithResilience("mywebapp1");
var result1 = await httpClient.GetFromJsonAsync<WeatherForecast[]>("/weatherforecast");.. and the failure happens on the 4th line.
Failed Aspire.Hosting.Testing.Tests.TestingFactoryTests.HttpClientGetTest [8 s]
Error Message:
System.Net.Http.HttpRequestException : Connection refused (localhost:5150)
---- System.Net.Sockets.SocketException : Connecti Failed Aspire.Hosting.Testing.Tests.TestingFactoryTests.HttpClientGetTest [8 s]
Error Message:
System.Net.Http.HttpRequestException : Connection refused (localhost:5150)
---- System.Net.Sockets.SocketException : Connection refused
Stack Trace:
at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.<SendCoreAsync>g__Core|5_0(HttpRequestMessage request, Boolean useAsync, CancellationToken cancellationToken)
at Microsoft.Extensions.Http.Resilience.ResilienceHandler.<>c.<<SendAsync>b__3_0>d.MoveNext()
--- End of stack trace from previous location ---
at Polly.Outcome`1.ThrowIfException()
at Microsoft.Extensions.Http.Resilience.ResilienceHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.<SendCoreAsync>g__Core|5_0(HttpRequestMessage request, Boolean useAsync, CancellationToken cancellationToken)
at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
at System.Net.Http.Json.HttpClientJsonExtensions.<FromJsonAsyncCore>g__Core|12_0[TValue,TJsonOptions](HttpClient client, Task`1 responseTask, Boolean usingResponseHeadersRead, CancellationTokenSource linkedCTS, Func`4 deserializeMethod, TJsonOptions jsonOptions, CancellationToken cancellationToken)
at Aspire.Hosting.Testing.Tests.TestingFactoryTests.HttpClientGetTest() in /Users/ankj/dev/aspire/tests/Aspire.Hosting.Testing.Tests/TestingFactoryTests.cs:line 50
--- End of stack trace from previous location ---
----- Inner Stack Trace -----
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|285_0(AwaitableSocketAsyncEventArgs saea, ValueTas
Member
There was a problem hiding this comment.
note that the dev-certs not being installed is an issue I caused locally and got this error. On CI I think it is failing because the webapp fails due to the port being in use.
But we should be failing all the tests with that fixture if host fails to start. And if it hasn't started then should .WatchResourceAsync succeeding?
Member
There was a problem hiding this comment.
Does the webapp show up as Running as soon as it is dotnet run? If so, then this doesn't handle failures. And also if the webapp's host takes time to start up then WatchResourceAsync returning wouldn't mean that the resource is actually usable. Is there something else needed to check for that?
Edit: note that I'm new to this, and might be asking non-sensical questions!
Member
|
And |
Member
|
I think it would be useful to add |
Member
Author
|
@radical I think the I'd say its something that perhaps once worked but was broken somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were disabled in #4614
This PR should go in after #4444 (its merged with it). This will reenable the tests that were disabled and use the new testing APIs so that if/when this test fails again we will get a clearer picture of whether we are getting failures during build, or whether the app is starting and the container is unresponsive for reason.
Fixes #4613