Update the DistributedApplicationLifecycle to use shared terminology#2432
Merged
Update the DistributedApplicationLifecycle to use shared terminology#2432
DistributedApplicationLifecycle to use shared terminology#2432Conversation
davidfowl
approved these changes
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I first saw the text used to describe the shutting down of the app when reviewing the new Aspire Learn module, I thought it was a typo. We should really be consistent with the other app hosts in the .NET ecosystem.
For example, consider the
Microsoft.Hosting.Lifetime:Note
The casing of the
Ctrl, a+instead of a-, and the term "shut down".Microsoft Reviewers: Open in CodeFlow