Skip to content

Fix failing test after log message updated to reference aka.ms/aspire/devcerts#15043

Merged
danegsta merged 2 commits intodanegsta/trustLogfrom
copilot/sub-pr-14666
Mar 7, 2026
Merged

Fix failing test after log message updated to reference aka.ms/aspire/devcerts#15043
danegsta merged 2 commits intodanegsta/trustLogfrom
copilot/sub-pr-14666

Conversation

Copy link
Contributor

Copilot AI commented Mar 7, 2026

After updating the untrusted dev cert warning messages to replace dotnet dev-certs command instructions with See https://aka.ms/aspire/devcerts for more information., the test DcpHost_WithUntrustedDeveloperCertificate_ShowsNotificationAndLogsWarning was asserting the log message contained the appHostDirectory path — which is no longer included in the new message format.

Changes:

  • Remove now-unnecessary appHostDirectory/configuration setup (with AppHost:Directory) from the test
  • Replace string.Format assertion (which was substituting {0} with the path) with a direct equality check against InteractionStrings.DeveloperCertificateNotFullyTrustedMessage
  • Update the log content assertion to verify aka.ms/aspire/devcerts URL is present instead of appHostDirectory

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…log message update

Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Copilot AI changed the title [WIP] Add logging for untrusted dev cert in app host Fix failing test after log message updated to reference aka.ms/aspire/devcerts Mar 7, 2026
@danegsta danegsta marked this pull request as ready for review March 7, 2026 21:25
@danegsta danegsta requested a review from mitchdenny as a code owner March 7, 2026 21:25
@danegsta danegsta merged commit db607d3 into danegsta/trustLog Mar 7, 2026
3 of 4 checks passed
@danegsta danegsta deleted the copilot/sub-pr-14666 branch March 7, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants