GenAI tools view: move description to expanded content and sort by name#15040
Open
JamesNK wants to merge 6 commits intorelease/13.2from
Open
GenAI tools view: move description to expanded content and sort by name#15040JamesNK wants to merge 6 commits intorelease/13.2from
JamesNK wants to merge 6 commits intorelease/13.2from
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15040Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15040" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GenAI visualizer “Tools” tab in the Aspire Dashboard to make tool browsing cleaner and easier by relocating descriptions into the expanded accordion content and sorting tools alphabetically.
Changes:
- Sort function tools by
ToolDefinition.Namein the Tools accordion. - Move tool description from the accordion header into the expanded body, with updated styling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Aspire.Dashboard/Components/Dialogs/GenAIVisualizerDialog.razor | Sorts displayed tools by name and renders the description inside expanded content instead of the heading. |
| src/Aspire.Dashboard/Components/Dialogs/GenAIVisualizerDialog.razor.css | Adds styling for the moved description and tweaks tool footer emphasis. |
| { | ||
| <FluentAccordion Class="tools-list"> | ||
| @foreach (var toolVM in Content.ToolDefinitions.Where(t => t.ToolDefinition.Type == "function")) | ||
| @foreach (var toolVM in Content.ToolDefinitions.Where(t => t.ToolDefinition.Type == "function").OrderBy(t => t.ToolDefinition.Name)) |
There was a problem hiding this comment.
The new alphabetical sort uses the default string comparer, which is culture-sensitive and case-sensitive. Elsewhere in the Dashboard, list ordering is typically made explicit (e.g., StringComparer.OrdinalIgnoreCase) to keep ordering predictable across cultures/casing. Consider supplying an explicit comparer (or a shared comparer) when sorting tool names.
…ender description as markdown
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22797701012 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The tools view didn't display well with complex, real world content.
Update the GenAI visualizer tools view in the Dashboard:
After:
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: