Skip to content

[automated] Unquarantine 11 stable tests with zero failures in 215 runs#14040

Merged
radical merged 4 commits intomainfrom
copilot/unquarantine-stable-tests
Jan 21, 2026
Merged

[automated] Unquarantine 11 stable tests with zero failures in 215 runs#14040
radical merged 4 commits intomainfrom
copilot/unquarantine-stable-tests

Conversation

Copy link
Contributor

Copilot AI commented Jan 21, 2026 •
edited
Loading

Summary

This PR unquarantines 11 tests that have been stable with zero failures in their latest 215 runs.

  • Remove [QuarantinedTest] attribute from 11 stable tests
  • Fix missing using statement in NodeFunctionalTests
  • Build and verify affected test projects
  • Prepare PR with proper tracking issue references

Tests Unquarantined

Test Method File Issue
TracingEnablesTheRightActivitySource_Keyed tests/Aspire.Azure.AI.OpenAI.Tests/ConformanceTests.cs #9916
NewCommandDoesNotPromptForOutputPathIfSpecifiedOnCommandLine tests/Aspire.Cli.Tests/Commands/NewCommandTests.cs #11222
NewCommandDoesNotPromptForTemplateIfSpecifiedOnCommandLine tests/Aspire.Cli.Tests/Commands/NewCommandTests.cs #10979
NewCommandInteractiveFlowSmokeTest tests/Aspire.Cli.Tests/Commands/NewCommandTests.cs #11099
NewCommandWithChannelOptionAutoSelectsHighestVersion tests/Aspire.Cli.Tests/Commands/NewCommandTests.cs None
NewCommandWithChannelOptionUsesSpecifiedChannel tests/Aspire.Cli.Tests/Commands/NewCommandTests.cs None
VerifyNpmAppWorks tests/Aspire.Hosting.JavaScript.Tests/NodeFunctionalTests.cs #8870
StartResourceForcesStart tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs #10086
ExecuteCommandAsync_HasReplicas_Failure_CalledPerReplica tests/Aspire.Hosting.Tests/ResourceCommandServiceTests.cs #9834
WithHttpCommand_ResultsInExpectedResultForStatusCode tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs #9670
WithHttpCommand_UsesNamedHttpClient tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs #9800

Changes

  • Removed [QuarantinedTest] attribute from all listed tests using QuarantineTools
  • Fixed missing using statement in NodeFunctionalTests.cs (QuarantineTools bug removed required imports)
  • These tests have demonstrated stability with 215 consecutive runs without failures

Verification

✅ Built test project(s) successfully

  • Aspire.Azure.AI.OpenAI.Tests
  • Aspire.Cli.Tests
  • Aspire.Hosting.JavaScript.Tests
  • Aspire.Hosting.Tests

Related Issues

Fixes #9916
Fixes #11222
Fixes #10979
Fixes #11099
Fixes #8870
Fixes #10086
Fixes #9834
Fixes #9670
Fixes #9800

Note: Two tests (NewCommandWithChannelOptionAutoSelectsHighestVersion and NewCommandWithChannelOptionUsesSpecifiedChannel) did not have tracking issues.

Original prompt

This section details on the original issue you should resolve

<issue_title>[automated] Unquarantine stable tests</issue_title>
<issue_description>

Unquarantine Candidates

The following quarantined tests have been stable with zero failures in their latest 180 runs and are candidates for unquarantining.

Last updated: 2026-01-21 19:23:51 UTC

Instructions for Copilot

Use the test-disabler agent to unquarantine the tests listed below. For each test:

  1. Remove the [Quarantine] attribute from the test method
  2. Include a Fixes <issue-url> line in the PR description for each tracking issue so they are automatically closed on merge
  3. If a test does not have a tracking issue (marked as "None" below), note this in the PR description

Candidates

Tracking Issue Runs Failures Test
#9916 215 0 Aspire.Azure.AI.OpenAI.Tests.ConformanceTests.TracingEnablesTheRightActivitySource_Keyed
#11222 215 0 Aspire.Cli.Tests.Commands.NewCommandTests.NewCommandDoesNotPromptForOutputPathIfSpecifiedOnCommandLine
#10979 215 0 Aspire.Cli.Tests.Commands.NewCommandTests.NewCommandDoesNotPromptForTemplateIfSpecifiedOnCommandLine
#11099 215 0 Aspire.Cli.Tests.Commands.NewCommandTests.NewCommandInteractiveFlowSmokeTest
None 215 0 Aspire.Cli.Tests.Commands.NewCommandTests.NewCommandWithChannelOptionAutoSelectsHighestVersion
None 215 0 Aspire.Cli.Tests.Commands.NewCommandTests.NewCommandWithChannelOptionUsesSpecifiedChannel
#8870 215 0 Aspire.Hosting.JavaScript.Tests.NodeFunctionalTests.VerifyNpmAppWorks
#10086 215 0 Aspire.Hosting.Tests.DistributedApplicationTests.StartResourceForcesStart
#9834 215 0 Aspire.Hosting.Tests.ResourceCommandServiceTests.ExecuteCommandAsync_HasReplicas_Failure_CalledPerReplica
#9670 215 0 Aspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_ResultsInExpectedResultForStatusCode
#9800 215 0 Aspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_UsesNamedHttpClient

</issue_description>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@radical
Unquarantine stable tests with zero failures in 215 runs
0100fff 
Co-authored-by: radical <1472+radical@users.noreply.github.com>
@radical radical marked this pull request as ready for review January 21, 2026 19:29
@radical radical requested a review from mitchdenny as a code owner January 21, 2026 19:29
Copilot AI review requested due to automatic review settings January 21, 2026 19:29
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026 •
edited
Loading

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14040

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14040"

@radical
Copy link
Member

radical commented Jan 21, 2026

@copilot validate that all the tests mentioned in the PR description and the ones re-enabled match and nothing was missed.

@radical
Fix missing using statement in NodeFunctionalTests
c973822 
Add back Aspire.TestUtilities using and license header that were removed by QuarantineTools

Co-authored-by: radical <1472+radical@users.noreply.github.com>
Copilot AI changed the title [WIP] Unquarantine stable tests with zero failures Unquarantine 11 stable tests with zero failures in 215 runs Jan 21, 2026
Copilot AI requested a review from radical January 21, 2026 19:38
Copilot AI reviewed Jan 21, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the [QuarantinedTest] attribute from tests that have demonstrated stability with 215 consecutive runs without failures, allowing them to run in regular CI pipelines again.

Changes:

  • Removed [QuarantinedTest] attributes from 10 stable test methods across 5 test files
  • Cleaned up unused Aspire.TestUtilities imports from files where QuarantinedTest is no longer used

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/Aspire.Azure.AI.OpenAI.Tests/ConformanceTests.cs Unquarantined TracingEnablesTheRightActivitySource_Keyed test and removed unused import
tests/Aspire.Cli.Tests/Commands/NewCommandTests.cs Unquarantined 4 tests related to NewCommand functionality
tests/Aspire.Hosting.JavaScript.Tests/NodeFunctionalTests.cs Unquarantined VerifyNpmAppWorks test and removed unused import and license header
tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs Unquarantined StartResourceForcesStart test
tests/Aspire.Hosting.Tests/ResourceCommandServiceTests.cs Unquarantined ExecuteCommandAsync_HasReplicas_Failure_CalledPerReplica test and removed unused import
tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs Unquarantined 2 tests for HTTP command functionality
Comments suppressed due to low confidence (1)

tests/Aspire.Hosting.JavaScript.Tests/NodeFunctionalTests.cs:1

  • The license header has been removed from this file. Other files in the same directory (e.g., AddNodeAppTests.cs) retain the standard .NET Foundation license header. For consistency with the rest of the codebase, the license header should be retained.
// Licensed to the .NET Foundation under one or more agreements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@radical radical requested review from JamesNK and joperezr January 21, 2026 19:42
@radical
Unquarantine NewCommandDoesNotPromptForTemplateIfSpecifiedOnCommandLi…
1d06c02 
…ne test

This test was missed in the initial unquarantine commit.

Co-authored-by: radical <1472+radical@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 21, 2026

@copilot validate that all the tests mentioned in the PR description and the ones re-enabled match and nothing was missed.

Validated. One test was missed in the original commits: NewCommandDoesNotPromptForTemplateIfSpecifiedOnCommandLine. Now unquarantined in commit 1d06c02. All 11 tests from the issue are now properly unquarantined.

@radical radical changed the title Unquarantine 11 stable tests with zero failures in 215 runs [automated] Unquarantine 11 stable tests with zero failures in 215 runs Jan 21, 2026
@radical radical enabled auto-merge (squash) January 21, 2026 20:03
@radical radical requested a review from sebastienros January 21, 2026 21:17
@radical radical merged commit 9606d1d into main Jan 21, 2026
304 checks passed
@radical radical deleted the copilot/unquarantine-stable-tests branch January 21, 2026 23:41
@dotnet-policy-service dotnet-policy-service bot added this to the 13.2 milestone Jan 21, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@JamesNK JamesNK JamesNK approved these changes

@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

@radical radical Awaiting requested review from radical

@joperezr joperezr Awaiting requested review from joperezr

@sebastienros sebastienros Awaiting requested review from sebastienros

Assignees

@radical radical

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

13.2

Development

Successfully merging this pull request may close these issues.

Failing test: Aspire.Azure.AI.OpenAI.Tests.ConformanceTests.TracingEnablesTheRightActivitySource_Keyed Failing test: Aspire.Hosting.Tests.ResourceCommandServiceTests.ExecuteCommandAsync_HasReplicas_Failure_CalledPerReplica Failing test: Aspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_UsesNamedHttpClient Flaky test: Aspire.Hosting.Tests.WithHttpCommandTests.WithHttpCommand_ResultsInExpectedResultForStatusCode [Failing test]: Aspire.Hosting.NodeJs.Tests.NodeFunctionalTests.VerifyNpmAppWorks
Failing test: Aspire.Hosting.Tests.DistributedApplicationTests.StartResourceForcesStart [Failing test]: Quarantine NewCommandDoesNotPromptForTemplateIfSpecifiedOnCommandLine (Flaky) Failing test: Aspire.Cli.Tests.Commands.NewCommandTests.NewCommandInteractiveFlowSmokeTest [Failing test]: Aspire.Cli.Tests.Commands.NewCommandTests. NewCommandDoesNotPromptForOutputPathIfSpecifiedOnCommandLine [automated] Unquarantine stable tests

4 participants

@radical @JamesNK