Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13767Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13767" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two flaky Playwright tests in the Aspire Dashboard by improving timeout handling and adding explicit wait conditions for page navigation and state changes.
Key changes:
- Replace hardcoded timeout value with
TestConstants.LongTimeoutDurationfor consistency - Add explicit wait for URL navigation after login to avoid race conditions
- Close settings dialog before page reload to ensure state persistence
- Replace custom retry logic with Playwright's native assertion mechanism
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Aspire.Dashboard.Tests/Integration/Playwright/Infrastructure/PlaywrightFixture.cs | Replaces hardcoded 30_000ms timeout with TestConstants.LongTimeoutDuration constant for consistency with the rest of the codebase |
| tests/Aspire.Dashboard.Tests/Integration/Playwright/BrowserTokenAuthenticationTests.cs | Removes QuarantinedTest attribute and adds explicit WaitForURLAsync call to wait for navigation completion after login, fixing the timeout issue |
| tests/Aspire.Dashboard.Tests/Integration/Playwright/AppBarTests.cs | Removes ActiveIssue for macOS, adds explicit dialog close before page reload, replaces custom retry logic with Playwright's ToBeCheckedAsync(), and ensures consistent timeout handling throughout |
radical
approved these changes
Jan 6, 2026
Member
|
Are these tests easily runnable locally? |
Member
Author
Yes. dotnet test runs them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I ran these in a loop locally and they passed after changes. Hopefully no trouble on CI.
Fixes #7921
Fixes #9152