Skip to content

Bump Aspire branding from 13.1 to 13.2#13474

Merged
joperezr merged 3 commits intomainfrom
copilot/bump-branding-to-13-2
Dec 10, 2025
Merged

Bump Aspire branding from 13.1 to 13.2#13474
joperezr merged 3 commits intomainfrom
copilot/bump-branding-to-13-2

Conversation

Copy link
Contributor

Copilot AI commented Dec 10, 2025

Description

Updates Aspire version branding from 13.1 to 13.2 for the next release cycle.

Changes

  • eng/Versions.props: MinorVersion 1 → 2
  • .github/policies/milestoneAssignment.prClosed.yml:
    • Main branch milestone: 13.1 → 13.2
    • Release branch policy: release/9.4release/13.1 with milestone 13.1

Template files unchanged—they were simplified in commit 959aac9 to work across all versions without version-specific configuration.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No
Original prompt

Take a look at the changes made in PR #12527 where we bumped the branding from 13.0 to 13.1, and now make the equivalent changes in main branch to bump the branding again now from 13.1 to 13.2


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Update version and milestone references:
- eng/Versions.props: MinorVersion 1 -> 2
- .github/policies/milestoneAssignment.prClosed.yml: milestone 13.1 -> 13.2

Note: Template files no longer contain version-specific configuration after
the template simplification in commit 959aac9, so no template changes needed.

Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>
Copilot AI changed the title [WIP] Update branding from 13.1 to 13.2 Bump Aspire branding from 13.1 to 13.2 Dec 10, 2025
Copilot AI requested a review from joperezr December 10, 2025 21:44
@joperezr
Copy link
Member

@copilot as part of these changes, can we also update the policy for merges happening on the release branch to make sure they get assigned the 13.1 milestone? Looks like that hasn't been updated since 9.4, but is very important as well. Policy is also located in the file where you updated the milestone assignement for PRs in main and looks like:

    - if:
      - payloadType: Pull_Request
      - isAction:
          action: Closed
      - targetsBranch:
          branch: release/9.4
      then:
      - removeMilestone
      - addMilestone:
          milestone: 9.4.2
      description: '[Milestone Assignments] Assign Milestone to PRs merged to release/9.4 branch'

Let's update that to listen for merges in branch release/13.1 instead, and to add the 13.1 milestone

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13474

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13474"

@davidfowl davidfowl marked this pull request as ready for review December 10, 2025 22:33
Copilot AI review requested due to automatic review settings December 10, 2025 22:33
@davidfowl davidfowl enabled auto-merge (squash) December 10, 2025 22:33
@davidfowl davidfowl disabled auto-merge December 10, 2025 22:35
Update the milestone assignment policy for the release branch:
- Branch: release/9.4 -> release/13.1
- Milestone: 9.4.2 -> 13.1

This ensures PRs merged to the release/13.1 branch get the correct milestone assigned.

Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Aspire's version branding from 13.1 to 13.2 for the next release cycle. The changes are minimal and focused, affecting only the core version properties and milestone assignment configuration.

Key Changes:

  • Increments minor version from 1 to 2 in version properties
  • Updates automated milestone assignment to use 13.2 for merged PRs

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/Versions.props Updates MinorVersion property from 1 to 2, establishing 13.2.0-preview.1 as the new version
.github/policies/milestoneAssignment.prClosed.yml Updates milestone assignment for PRs merged to main branch from 13.1 to 13.2

Review Summary: The changes are correct and complete. This PR properly updates the Aspire version branding following the established pattern. Template files do not require updates as they were simplified in a previous commit to work across all versions. No issues identified.

Copy link
Contributor Author

Copilot AI commented Dec 10, 2025

@copilot as part of these changes, can we also update the policy for merges happening on the release branch to make sure they get assigned the 13.1 milestone? Looks like that hasn't been updated sinc...

Updated in commit ccb5d29. The release branch milestone assignment policy now targets release/13.1 and assigns the 13.1 milestone.

@joperezr joperezr enabled auto-merge (squash) December 10, 2025 22:36
@joperezr joperezr merged commit 49eb5f0 into main Dec 10, 2025
289 checks passed
@joperezr joperezr deleted the copilot/bump-branding-to-13-2 branch December 10, 2025 23:00
@dotnet-policy-service dotnet-policy-service bot added this to the 13.2 milestone Dec 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants