Remove Obsolete models from AIFoundry and GitHub.Models#12755
Remove Obsolete models from AIFoundry and GitHub.Models#12755eerhardt merged 1 commit intodotnet:mainfrom
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12755Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12755" |
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete API members from two model definition files, simplifying the codebase by cleaning up deprecated aliases that have been superseded by properly-named equivalents in the generated model files.
Key Changes:
- Removed all obsolete model property definitions from
AIFoundryModel.Obsolete.csandGitHubModel.Obsolete.cs - Replaced actual obsolete code with commented-out examples showing the pattern for future reference
- Removed the
using System.ComponentModel;directive that is no longer needed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Aspire.Hosting.GitHub.Models/GitHubModel.Obsolete.cs |
Removed obsolete model aliases (e.g., OpenAIGPT41 → OpenAIGpt41) and replaced with example template |
src/Aspire.Hosting.Azure.AIFoundry/AIFoundryModel.Obsolete.cs |
Removed obsolete model aliases and an entire obsolete class (MistralAi), replaced with example template |
| /// <inheritdoc cref="MistralAI.Codestral2501"/> | ||
| public static readonly AIFoundryModel MistralSmall2503 = new() { Name = "mistral-small-2503", Version = "1", Format = "Mistral AI" }; | ||
| } | ||
| // example |
There was a problem hiding this comment.
[nitpick] The comment 'example' should be capitalized to 'Example' for consistency with standard documentation practices.
| // example | |
| // Example |
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| public static readonly GitHubModel OpenAIGPT4oMini = new() { Id = "openai/gpt-4o-mini" }; | ||
| } | ||
| // example |
There was a problem hiding this comment.
[nitpick] The comment 'example' should be capitalized to 'Example' for consistency with standard documentation practices.
| // example | |
| // Example |
|
/backport to release/13.0 |
|
Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/19145650769 |
Description
We don't want to ship with these new Obsolete APIs. These libraries haven't shipped stable yet, so backwards compatibility isn't a concern.