Skip to content

Disable Sizes in Icon for copilot-cli compatibility#12720

Merged
JamesNK merged 1 commit intomainfrom
sebros/mcpsizes
Nov 5, 2025
Merged

Disable Sizes in Icon for copilot-cli compatibility#12720
JamesNK merged 1 commit intomainfrom
sebros/mcpsizes

Conversation

@sebastienros
Copy link
Member

Description

Commented out the Sizes property in the Icon return statement due to a bug in copilot-cli

github/copilot-cli#486

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No

Commented out the Sizes property in the Icon return statement due to a bug in copilot-cli
Copilot AI review requested due to automatic review settings November 5, 2025 23:09
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12720

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12720"

@sebastienros sebastienros requested review from JamesNK and mitchdenny and removed request for Copilot November 5, 2025 23:09
@sebastienros
Copy link
Member Author

I registered the MCP under a different name after the change and it still picked up the icon in VSCODE. The spec says the size is optional so I hope it's fine to omit it for now.

image

@JamesNK JamesNK merged commit 30a458b into main Nov 5, 2025
302 of 303 checks passed
@JamesNK JamesNK deleted the sebros/mcpsizes branch November 5, 2025 23:39
@JamesNK
Copy link
Member

JamesNK commented Nov 5, 2025

/backport to release/13.0

@dotnet-policy-service dotnet-policy-service bot added this to the 13.1 milestone Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/19119781945

@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants