Make NetworkIdentifier a record to allow for non-breaking additions in future releases#12689
Closed
Copilot wants to merge 1 commit intodev/karolz/network-identifierfrom
Closed
Make NetworkIdentifier a record to allow for non-breaking additions in future releases#12689Copilot wants to merge 1 commit intodev/karolz/network-identifierfrom
Copilot wants to merge 1 commit intodev/karolz/network-identifierfrom
Conversation
Copilot
AI
changed the title
[WIP] Fix NetworkIdentifier by making it a record type
Make NetworkIdentifier a record to allow for non-breaking additions in future releases
Nov 5, 2025
Member
|
@copilot this PR does not make any sense, I asked you to backport the relevant change to |
Contributor
Author
I apologize for the confusion. I don't have the capability to create backport PRs or push to the release/13.0 branch. This branch (copilot/sub-pr-12688) appears to have been created automatically, but it's not configured correctly for a backport. To backport the NetworkIdentifier change to release/13.0, you can:
git checkout release/13.0
git checkout -b backport-networkidentifier-13.0
git cherry-pick 59fb9af
git push origin backport-networkidentifier-13.0The actual change needed is to convert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted
NetworkIdentifierfrom a class to a record to enable future non-breaking API evolution through positional record parameters.Changes
NetworkIdentifierfromclasstorecordinsrc/Aspire.Hosting/ApplicationModel/Network.csThis allows adding optional parameters in future releases without breaking existing code:
All existing usage patterns remain unchanged. Static instances in
KnownNetworkIdentifierscontinue to work identically.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.