Skip to content

Add ModelContextProtocol assemblies to signing list#12637

Merged
joperezr merged 1 commit intodotnet:mainfrom
joperezr:FixSigning
Nov 3, 2025
Merged

Add ModelContextProtocol assemblies to signing list#12637
joperezr merged 1 commit intodotnet:mainfrom
joperezr:FixSigning

Conversation

@joperezr
Copy link
Member

@joperezr joperezr commented Nov 3, 2025 •
edited
Loading

Description

The official build is currently failing with:

##[error].packages\microsoft.dotnet.arcade.sdk\11.0.0-beta.25509.1\tools\Sign.proj(76,5): error SIGN004: Signing 3rd party library 'D:\a\_work\1\s\artifacts\tmp\Release\ContainerSigning\369\tools/ModelContextProtocol.AspNetCore.dll' with Microsoft certificate 'Microsoft400'. The library is considered 3rd party library due to its copyright: '© Anthropic and Contributors.'.
D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\11.0.0-beta.25509.1\tools\Sign.proj(76,5): error SIGN004: Signing 3rd party library 'D:\a\_work\1\s\artifacts\tmp\Release\ContainerSigning\369\tools/ModelContextProtocol.AspNetCore.dll' with Microsoft certificate 'Microsoft400'. The library is considered 3rd party library due to its copyright: '© Anthropic and Contributors.'.
##[error].packages\microsoft.dotnet.arcade.sdk\11.0.0-beta.25509.1\tools\Sign.proj(76,5): error SIGN004: Signing 3rd party library 'D:\a\_work\1\s\artifacts\tmp\Release\ContainerSigning\370\tools/ModelContextProtocol.Core.dll' with Microsoft certificate 'Microsoft400'. The library is considered 3rd party library due to its copyright: '© Anthropic and Contributors.'.
D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\11.0.0-beta.25509.1\tools\Sign.proj(76,5): error SIGN004: Signing 3rd party library 'D:\a\_work\1\s\artifacts\tmp\Release\ContainerSigning\370\tools/ModelContextProtocol.Core.dll' with Microsoft certificate 'Microsoft400'. The library is considered 3rd party library due to its copyright: '© Anthropic and Contributors.'.
##[error].packages\microsoft.dotnet.arcade.sdk\11.0.0-beta.25509.1\tools\Sign.proj(76,5): error SIGN004: Signing 3rd party library 'D:\a\_work\1\s\artifacts\tmp\Release\ContainerSigning\371\tools/ModelContextProtocol.dll' with Microsoft certificate 'Microsoft400'. The library is considered 3rd party library due to its copyright: '© Anthropic and Contributors.'.
D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\11.0.0-beta.25509.1\tools\Sign.proj(76,5): error SIGN004: Signing 3rd party library 'D:\a\_work\1\s\artifacts\tmp\Release\ContainerSigning\371\tools/ModelContextProtocol.dll' with Microsoft certificate 'Microsoft400'. The library is considered 3rd party library due to its copyright: '© Anthropic and Contributors.'.

These changes should fix that. (No real way to validate until we do an actual full build.

cc: @radical @JamesNK @halter73

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

Copilot AI review requested due to automatic review settings November 3, 2025 21:28
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12637

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12637"

Copilot AI reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds code signing configuration for three new ModelContextProtocol library DLLs as third-party dependencies. The changes ensure these assemblies will be properly signed during the build process using the standard 3PartySHA2 certificate.

Key Changes

  • Added signing entries for three ModelContextProtocol assemblies (Core, AspNetCore, and the main library)

@joperezr
Copy link
Member Author

joperezr commented Nov 3, 2025

/backport to release/13.0

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/19049909480

@github-actions github-actions bot mentioned this pull request Nov 3, 2025
Merged
@radical
Copy link
Member

radical commented Nov 3, 2025

Manually run the pipeline

@joperezr joperezr merged commit b8bbc7e into dotnet:main Nov 3, 2025
589 of 592 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 13.1 milestone Nov 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@JamesNK JamesNK JamesNK approved these changes

@eerhardt eerhardt eerhardt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

13.1

Development

Successfully merging this pull request may close these issues.

5 participants

@joperezr @radical @JamesNK @eerhardt