Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12556Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12556" |
mitchdenny
approved these changes
Oct 31, 2025
davidfowl
approved these changes
Oct 31, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for MCP (Model Context Protocol) endpoint to work with HTTP-only configuration, ensuring that HTTPS redirection is only enabled when all endpoints (Frontend, OTLP gRPC, OTLP HTTP, and MCP) are using HTTPS.
Key changes:
- Updated the
isAllHttpscheck to include the MCP endpoint when determining whether to enable HTTPS redirection - Added a test to verify that the MCP endpoint works correctly when configured with HTTP while other endpoints use HTTPS
- Introduced a local variable to improve code readability when iterating over grouped endpoints
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Aspire.Dashboard/DashboardWebApplication.cs | Added MCP endpoint to the HTTPS check and extracted grouped endpoints to a local variable |
| tests/Aspire.Dashboard.Tests/Integration/McpServiceTests.cs | Added test case to verify MCP endpoint works with HTTP-only configuration |
Member
Author
|
/backport to release/13.0 |
Contributor
|
Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/18969710303 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix dashboard configuration error when MCP endpoint is the only non-HTTPS endpoint.
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate