Properly containerize CI/PR builds#4698
Merged
ellahathaway merged 3 commits intodotnet:mainfrom Jan 9, 2025
Merged
Conversation
Member
Author
|
This is blocked on dotnet/arcade#15342. |
Member
Author
|
Will publish once the updated arcade SDK with the changes from dotnet/arcade#15385 flow in. |
…to containerize-linux
Member
Author
|
Not sure why this got merged without an approval? @dotnet/dnceng - the settings on this repo may have to be adjusted. |
Member
|
Main branch protections don't require approvals. @mmitche is this okay for this repo? |
Member
|
We use this so that maestro can auto merge main arcade updates. Let me see what I can do. |
Member
|
If we could set it so dotnet-maestro bot can merge it's own stuff, that would be fine, and then require approvals for everyone else. |
Member
|
I switched over to using rulesets, which have this kind of flexibiliy. Let's see what happens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal builds were not being properly containerized with the 1ES templates. This PR also updates the container from cbl-mariner 2.0 to azurelinux 3.0
Proper containerization is needed to test the validity of the MicroBuild signing plugin tasks.
Test build