Skip to content

Update Darc.md documentation for Version.Details.props and SkipProperty attribute changes#5346

Merged
dkurepa merged 8 commits intomainfrom
copilot/update-darc-docs-for-version-details
Oct 8, 2025
Merged

Update Darc.md documentation for Version.Details.props and SkipProperty attribute changes#5346
dkurepa merged 8 commits intomainfrom
copilot/update-darc-docs-for-version-details

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 7, 2025

Original prompt

This section details on the original issue you should resolve

<issue_title>Update Darc.md documentation for Version.Details.props and SkipProperty attribute changes</issue_title>
<issue_description>Update the Darc.md documentation to reflect changes implemented in the following PRs:

Key points to address:

  1. Version.Details.props File

    • Describe the addition of the new Version.Details.props file.
    • Document that if Version.Details.props exists, it will be used.
    • Explain when and how this file is generated or consumed.
  2. SkipProperty Attribute in Version.Details.xml

    • Introduce and document the SkipProperty attribute that can be added in Version.Details.xml.
    • Describe its purpose and how it affects dependency management.
  3. Other Relevant Changes

    • Summarize any additional relevant changes from the referenced PRs, such as header generation behavior for repos with only SkipProperty dependencies.

Ensure examples and configuration/process details are clear for users maintaining or integrating with Darc-managed repositories.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #5345

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ty attribute

Co-authored-by: dkurepa <91743470+dkurepa@users.noreply.github.com>
Copilot AI changed the title [WIP] Update Darc.md documentation for version details changes Update Darc.md documentation for Version.Details.props and SkipProperty attribute changes Oct 7, 2025
Copilot AI requested a review from dkurepa October 7, 2025 15:14
docs/Darc.md Outdated
- If ALL dependencies from a repository have `SkipProperty="true"`, no repository header
comment will be generated in `Version.Details.props`

**When to use SkipProperty:**
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove this part

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in a2a0881

Co-authored-by: dkurepa <91743470+dkurepa@users.noreply.github.com>
Copilot AI requested a review from dkurepa October 7, 2025 19:52
docs/Darc.md Outdated
```xml
<Import Project="Version.Details.props" Condition="Exists('Version.Details.props')" />
```
3. Run `darc update-dependencies` to regenerate version properties
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot you can also remove the steps 2. 3. 4. 5. Instead say that the file will be populated during the next dependency update, and that a merge policy will provide further instructions

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 9c199d8. Simplified the migration steps to just creating an empty file, with a note that it will be populated automatically and the merge policy will provide further instructions.

@dkurepa dkurepa marked this pull request as ready for review October 7, 2025 19:59
Copilot AI review requested due to automatic review settings October 7, 2025 19:59
Co-authored-by: dkurepa <91743470+dkurepa@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates Darc documentation to describe the new Version.Details.props file workflow and the SkipProperty attribute, and adjusts related command descriptions.

  • Adds TOC entry and a dedicated section detailing Version.Details.props and SkipProperty.
  • Updates add-dependency command description to reflect new property generation logic.
  • Provides migration guidance from legacy Versions.props usage.


When adding a new dependency, only name and type are required. For a detailed
discussion on adding new dependencies to a repository, see [Adding dependencies to a repository](#adding-dependencies-to-a-repository)
discussion on adding new dependencies to a repository, see [Adding dependencies to a repository](#adding-dependencies-to-a-repository).
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name is incorrect; it should be Version.Details.xml (plural 'Details').

Suggested change
discussion on adding new dependencies to a repository, see [Adding dependencies to a repository](#adding-dependencies-to-a-repository).
Add a new tracked dependency to the Version.Details.xml file in your local repo.

Copilot uses AI. Check for mistakes.

See also [Version.Details.props and the SkipProperty attribute](#versiondetailsprops-and-the-skipproperty-attribute)
for information on how dependency properties are generated.

Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize GitHub properly.

Suggested change
into the remote GitHub or AzDO repository, the dependency can be updated by Maestro++

Copilot uses AI. Check for mistakes.

**Key characteristics:**
- **Auto-generated**: This file is created and maintained automatically by Maestro dependency flow.
- **Do not manually edit**: Changes will be overwritten by automation during dependency updates.
Copy link

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding an explicit note that Version.Details.props must be checked into source control (not gitignored) so automation can update it via PRs.

Suggested change
- **Do not manually edit**: Changes will be overwritten by automation during dependency updates.
- **Do not manually edit**: Changes will be overwritten by automation during dependency updates.
- **Must be checked into source control**: This file **must not** be gitignored. It should be committed to your repository so that automation can update it via pull requests.

Copilot uses AI. Check for mistakes.
Copilot AI requested a review from dkurepa October 7, 2025 20:01
dkurepa and others added 4 commits October 8, 2025 09:52
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
@dkurepa dkurepa merged commit a026082 into main Oct 8, 2025
2 of 6 checks passed
@dkurepa dkurepa deleted the copilot/update-darc-docs-for-version-details branch October 8, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Darc.md documentation for Version.Details.props and SkipProperty attribute changes

4 participants