Add BAR build links to dependency PR descriptions#5227
Merged
Conversation
Co-authored-by: premun <7013027+premun@users.noreply.github.com>
Co-authored-by: premun <7013027+premun@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add a BAR build link into dependency PR descriptions
Add BAR build links to dependency PR descriptions
Aug 29, 2025
premun
reviewed
Aug 29, 2025
test/ProductConstructionService.DependencyFlow.Tests/PullRequestBuilderTests.cs
Outdated
Show resolved
Hide resolved
src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestBuilder.cs
Show resolved
Hide resolved
…ove duplicate test method Co-authored-by: premun <7013027+premun@users.noreply.github.com>
premun
reviewed
Aug 29, 2025
src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestBuilder.cs
Outdated
Show resolved
Hide resolved
premun
reviewed
Aug 29, 2025
src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestBuilder.cs
Outdated
Show resolved
Hide resolved
…ndencyFlow/PullRequestBuilder.cs
Co-authored-by: premun <7013027+premun@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds BAR (Build Asset Registry) build links to dependency PR descriptions, enhancing the build information with direct links to the build visualization. The implementation includes converting repository URLs to appropriate slugs and generating enhanced build links that combine Azure DevOps build links with BAR build details.
Key changes:
- Made
GenerateCodeFlowPRDescriptionmethod asynchronous to support enhanced build link generation - Added comprehensive unit tests for enhanced build links with both GitHub and Azure DevOps repositories
- Implemented repository URL to slug conversion utilities for BarViz URL generation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| PullRequestBuilder.cs | Added async GetBarVizBuildLinkAsync method and repository URL slug conversion logic |
| PullRequestUpdater.cs | Updated calls to GenerateCodeFlowPRDescription to handle async signature |
| PullRequestBuilderTests.cs | Added comprehensive unit tests for enhanced build links with BAR details |
src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestBuilder.cs
Outdated
Show resolved
Hide resolved
src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestBuilder.cs
Show resolved
Hide resolved
adamzip
previously approved these changes
Sep 1, 2025
src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestBuilder.cs
Outdated
Show resolved
Hide resolved
dkurepa
reviewed
Sep 1, 2025
src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestBuilder.cs
Outdated
Show resolved
Hide resolved
dkurepa
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5226