Add new filters into BarViz subscription page#5208
Merged
Conversation
Co-authored-by: premun <7013027+premun@users.noreply.github.com>
Co-authored-by: premun <7013027+premun@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add new filters to the subscription page
Add new subscription filters for forward/backflows and partial matching
Aug 27, 2025
premun
reviewed
Aug 27, 2025
src/ProductConstructionService/ProductConstructionService.BarViz/Pages/Subscriptions.razor
Outdated
Show resolved
Hide resolved
…iz/Pages/Subscriptions.razor
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds new filtering capabilities to the subscription page for better differentiation between forward flow and backflow subscriptions in the Product Construction Service BarViz. The changes enable users to filter VMR codeflow subscriptions by direction and include auto-completion for partial filter matches.
- Added 4 new filter keywords (
:ff,:forwardflow,:bf,:backflow) for filtering forward flows and backflows - Implemented partial matching auto-completion that expands unambiguous filter prefixes
- Enhanced the filtering system with comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/ProductConstructionService.BarViz.Tests/SubscriptionExtensionTests.cs |
New comprehensive test file covering extension methods and filter functionality |
test/ProductConstructionService.BarViz.Tests/RedirectsTests.cs |
Refactored to use static method calls instead of instance methods |
src/ProductConstructionService/ProductConstructionService.BarViz/Pages/Subscriptions.razor |
Enhanced filtering logic with new filter types and partial matching capability |
oleksandr-didyk
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements two new filtering features for the subscription page:
New Filter Types
Added 4 new filter keywords to help distinguish between different types of VMR codeflow subscriptions:
:ffand:forwardflow- filters for forward flows (source-enabled subscriptions with target directory):bfand:backflow- filters for backflows (source-enabled subscriptions with source directory)These filters use the existing
IsForwardFlow()andIsBackflow()extension methods on theSubscriptionclass.Partial Matching Auto-completion
Enhanced the filter system to automatically expand partial filter matches when unambiguous:
:cautomatically applies:codeflow:forwardexpands to:forwardflow:backexpands to:backflow:f(could match:ffor:forwardflow) don't expandExample Usage
Fixes #5207.