Conversation
ghost
left a comment
There was a problem hiding this comment.
The azdoflow-nonbatched-all-checks-successful.ps1 test is still failing with the same symptoms.
"policy": {
"batchable": false,
"updateFrequency": "none",
"mergePolicies": [
{
"name": "AllChecksSuccessful",
"properties": {
"ignoreChecks": [
"'Work",
"item",
"linking'"
]
}
}
]
}
src/Maestro/tests/Scenarios/azdoflow-nonbatched-all-checks-successful.ps1
Outdated
Show resolved
Hide resolved
| Push-Location -Path $(Get-Repo-Location $targetRepoName) | ||
| Darc-Command add-dependency --name 'Foo' --type product --repo $sourceRepoUri | ||
| Darc-Command add-dependency --name 'Bar' --type product --repo $sourceRepoUri | ||
| Darc-Command @( "add-dependency", "--name", "Foo", "--type product", "--repo", "$sourceRepoUri" ) |
There was a problem hiding this comment.
| Darc-Command @( "add-dependency", "--name", "Foo", "--type product", "--repo", "$sourceRepoUri" ) | |
| Darc-Command @( "add-dependency", "--name", "Foo", "--type", "product", "--repo", "$sourceRepoUri" ) |
All the github tests are failing when adding dependencies due to a similar bug. Makes me think this approach is a little brittle and cumbersome to write? Not sure if I have a better suggestion yet though.
| Write-Host "" | ||
| Write-Host "Setting repository merge policy to standard" | ||
| Darc-Set-Repository-Policies $repoUri $branchName "--standard-automerge" | ||
| Darc-Set-Repository-Policies -repo $repoUri -branch $branchName -policyParams @( "--standard-automerge" ) |
There was a problem hiding this comment.
This test failed with:
https://github.com/maestro-auth-test/maestro-test1 @ 104674302 - Merge Policies: []
Repository merge policies should be standard, but were not
So the policy params are not getting interpreted correctly.
|
Only 8/13 tests are passing when running the tests in this branch against INT. Failed tests: |
|
Can we make sure to test this if we are not currently doing so? Discovering that test fail until we try to deploy to is not super efficient. |
|
@jcagme yeah, we're testing it now. For whatever reason, it seemed to have passed the smoke test previously before deployment, so I most likely just missed something then. |
src/Maestro/tests/Scenarios/azdoflow-nonbatched-all-checks-successful.ps1
Outdated
Show resolved
Hide resolved
ghost
left a comment
There was a problem hiding this comment.
With some quote trimming, I really like where this ended up. Thanks for this @jonfortescue
@riarenas enjoy