Conversation
|
Looks good! these tests need a lot of setup to run locally so let me run a quick test to see if everything keeps working fine. |
|
This breaks Darc-Command-Impl :( |
| Write-Host "Running 'darc $darcParams $darcAuthParams'" | ||
| $darcCommand = "`$commandOutput = $baseDarcCommand $darcAuthParams; if (`$LASTEXITCODE -ne 0) { Write-Host `${commandOutput};throw `"Darc command exited with exit code: `$LASTEXITCODE`" } else { `$commandOutput }" | ||
| Invoke-Expression $darcCommand | ||
| $commandOutput = & $darcTool $darcParams $darcAuthParams; if ($LASTEXITCODE -ne 0) { Write-Host ${commandOutput};throw "Darc command exited with exit code: $LASTEXITCODE" } else { $commandOutput } |
There was a problem hiding this comment.
Verb 'add-channel --name '658958354' --classification 'test'' is not recognized.
The " from $darcParams seem to be getting passed along, making it so it looks like the command is the entire string.
There was a problem hiding this comment.
I can't remember why I wrote it like that originally, but there may have been a fair bit of trial and error there related to quoting semantics and such. This needs some local testing prior to check-in.
There was a problem hiding this comment.
Yep, I'll be making sure to figure out this quote stuff.
mmitche
left a comment
There was a problem hiding this comment.
Please test before checking in.
|
@riarenas Tests are flaky but I'm able to get all of them to pass locally. You good with merging this? |
|
I tried running channels.ps1, and got: During the final teardown function. EDIT: aaaand that's totally expected because the channel tests delete the channels they create as part of the test. Nothing to see here. |
ghost
left a comment
There was a problem hiding this comment.
LGTM. Thanks for iterating on this Jon!
(make sure to squash merge)
|
Hey @jonfortescue, the tests are failing consistently after this PR merged. It's not flakiness. (also, you didn't squash merge :( ) |
|
The azdoflow-nonbatched-all-checks-successful test is broken because the merge policy is getting generated incorrectly. should look like this: The args are getting split by spaces. This is the one place where we don't want that. This is causing the PRs opened by the test to not be merged because the IgnoreChecks are not correct. The Github allChecksSuccessful is working because the ignoreCheck for that one does not include spaces. |
A few modifications to the powershell scripts to bring them up to standards