Fix incorrect WarningsAsErrors elements#1945
Merged
premun merged 3 commits intodotnet:mainfrom Jun 19, 2023
Merged
Conversation
ChadNedzlek
previously approved these changes
Jul 13, 2022
premun
approved these changes
Jun 19, 2023
Member
premun
left a comment
There was a problem hiding this comment.
Thanks @GrabYourPitchforks for noticing. Sorry for the long reaction time. Merging this now
This was referenced Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project file element
<WarningsAsErrors>is used to specify a list of warning codes that should be treated as errors. Passing true here has no meaning.If you're instead trying to say "treat all warnings as errors," the correct syntax is:
#2678