Add source-build option to build scripts#9989
Merged
tkapin merged 1 commit intodotnet:mainfrom Jul 26, 2022
oleksandr-didyk:feat-add-source-build-option
Merged
Add source-build option to build scripts#9989tkapin merged 1 commit intodotnet:mainfrom oleksandr-didyk:feat-add-source-build-option
tkapin merged 1 commit intodotnet:mainfrom
oleksandr-didyk:feat-add-source-build-option
Conversation
|
|
tkapin
requested changes
Jul 13, 2022
Member
|
@oleksandr-didyk - could you please also describe how did you test this change? @riarenas / @markwilkie - what is your preference regarding reviews of such changes? Do you want to be explicitly called for reviews of changes that might be affecting common arcade pieces such as the entry point scripts? |
tkapin
previously approved these changes
Jul 13, 2022
Member
tkapin
left a comment
There was a problem hiding this comment.
Nice, thanks for accepting my suggestion.
Contributor
Author
|
Update: removed left-over flag from changes made before the PR feedback |
crummel
previously approved these changes
Jul 20, 2022
MichaelSimons
previously approved these changes
Jul 20, 2022
Member
MichaelSimons
left a comment
There was a problem hiding this comment.
I have one question regarding windows. Overall it looks good.
a30f1a0
Contributor
Author
|
Update: reverted changes to |
MichaelSimons
approved these changes
Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/source-build#2674
Resulting changes were tested by source-building the xharness repository on:
mcr.microsoft.com/dotnet-buildtools/prereqs@sha256:4a2bbece99ec3115754839f141f4ebb8077bec516fab55d3cd28824d2fdfc9b521H2build19044.1826CC: @tkapin @MichaelSimons @riarenas