Backport native tools path promotion to release/3.x#9596
Merged
jonfortescue merged 3 commits intodotnet:release/3.xfrom Jul 19, 2022
Merged
Conversation
MattGal
reviewed
Jun 6, 2022
Member
MattGal
left a comment
There was a problem hiding this comment.
As noted in the others, files look OK, can you fill out https://github.com/dotnet/arcade/blob/2022-04-03-Scorecard-Update/Documentation/Policy/AskModeTellModeTemplate.md before merging and put it in the PR description?
Another question; has this been exercised anywhere yet? I'd really like to see some proof of that before merging changes to release branches.
MattGal
approved these changes
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9593.
Description
Backports the new "path promotion" option to native tools installation. This checks for native tools that already exist on the machine and promotes them to the path.
Customer Impact
Servicing branches will be unable to use the new functionality and thus will be unable to use native tools on machines. This will cause conflicts as they move to these new images.
Regression
No
Risk
Low risk. It has been tested in main and requires a variable to opt-in anyway.
Workarounds
No.