Set PrivateAssets to "all" on the X509Certificates references#9380
Merged
MattGal merged 1 commit intorelease/6.0from May 17, 2022
Merged
Set PrivateAssets to "all" on the X509Certificates references#9380MattGal merged 1 commit intorelease/6.0from
MattGal merged 1 commit intorelease/6.0from
Conversation
…nt bringing this dependency to indirect references of this package.
ericstj
reviewed
May 17, 2022
| <!-- Don't let it restore lower versions of this package, which can come transitively from NetStandard package restores (CSProj only) --> | ||
| <ItemGroup Condition="'$(MSBuildProjectExtension)' == '.csproj'" > | ||
| <PackageReference Include="System.Security.Cryptography.X509Certificates" Version="$(SystemSecurityCryptographyX509CertificatesVersion)" /> | ||
| <PackageReference Include="System.Security.Cryptography.X509Certificates" Version="$(SystemSecurityCryptographyX509CertificatesVersion)" PrivateAssets="All" /> |
Member
There was a problem hiding this comment.
This should be OK as a low risk fix to get things flowing.
Ideally no project should be bringing in packages from .NETCore 1.1 in our builds for .NET 7.0. We should try to drive these out over time. Probably first in main, only backporting things that are low-risk enough for servicing.
ericstj
approved these changes
May 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should prevent bringing this dependency to indirect references of arcade packages. @ericstj FYI.
To double check: