Skip to content

Conversation

@missymessa
Copy link
Member

This PR expands upon the existing documentation as we've rolled out more features since it was originally created. Feedback I'm looking for from reviewers:

  • If you've been involved with this epic, please check for accuracy in the statements made. Point out anything you feel is missing that I should add or expand upon.
  • If you haven't been involved with this epic, please check that it makes sense from a customer's point-of-view (for dnceng folks, it's currently enabled on Arcade and Arcade Services, so we technically are customers, too!).
  • If you think of other FAQ items to add, tell me about them and I'll address it.

Thanks everyone!

@missymessa
Copy link
Member Author

Need to fix that image with the weird spacing.

ChadNedzlek
ChadNedzlek previously approved these changes May 12, 2022
Copy link
Member

@markwilkie markwilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great Missy - thanks!

The Build Analysis Check is a service to improve the GitHub Pull Request experience by highlighting build and test information most helpful to .NET developers. Its goal is to make Pull Request results more actionable.

## What does it do?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add known issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulisesh what should we add in here about Known Issues?

- Link to the log of the specific step that failed
- Link to the Azure DevOps Test History for the pipeline
- Link to test history of the specific test
- Link to the Helix artifacts produced by a test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the known issue mention here too


Dive into the Known Issues documentation [here](KnownIssues.md).

## Unique Build Failures
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding some caveats to this? In other words, expand on the limitations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlitzelMendez @garath @ChadNedzlek anything you can think of that we should include in here for limitations on this? (I can link back to the blurb about technical limitations if that seems sufficient.)

Each Build Analysis page also includes a "was this helpful" link. This allows you to call out specific highlights or lowlights in your experience with the check. This feedback is then used by the Dev WF team to refine the analysis.
Each Build Analysis page also includes a "was this helpful" link. This allows you to call out specific highlights or lowlights in your experience with the check. This feedback is then used by the Dev WF team to refine the analysis.

## Known Issues
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a bit here about the fact that the actual issue keep track of the number of failed builds (like runfo). Also, there's a dashboard....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulisesh could you write a blurb to put in here about Known Issues. The users can click on the link to the Known Issue's doc for more information.

garath
garath previously approved these changes May 17, 2022
@missymessa missymessa dismissed stale reviews from garath and ChadNedzlek via ebc0b3f May 31, 2022 18:22
@missymessa
Copy link
Member Author

This PR has been open for quite some time and has information that is useful for customers. Merging this now. Outstanding feedback to be handled by: #9814

@missymessa missymessa merged commit a264eb1 into main Jun 27, 2022
@missymessa missymessa deleted the missymessa-9022 branch June 27, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants