OneLocBuild: Ensure AutoCompletePr setting is respected#9067
Merged
jonfortescue merged 1 commit intodotnet:mainfrom Apr 18, 2022
Merged
OneLocBuild: Ensure AutoCompletePr setting is respected#9067jonfortescue merged 1 commit intodotnet:mainfrom
jonfortescue merged 1 commit intodotnet:mainfrom
Conversation
AbhitejJohn
approved these changes
Apr 15, 2022
jonfortescue
approved these changes
Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
CreatePris false,isCreatePrSelectedis set butisAutoCompletePrSelectedis left unset. The build task interprets the unset value as true, which causes the task to try to auto complete the PR even if the behavior is unwanted. This change moves the setting outside of the conditional gated byCreatePrso that theAutoCompletePrsetting will always be passed into the task.See #9048
/cc @AbhitejJohn @jonfortescue