Conversation
src/Microsoft.DotNet.Arcade.Sdk/tools/VisualStudio.SetupPackage.vsmanproj
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Arcade.Sdk/tools/VisualStudio.InsertionManifests.targets
Outdated
Show resolved
Hide resolved
…e.vsmanproj Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
…nifests.targets Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
Yes I am planning to back port this change to release/6.0 But unfortunately when I did more tests in winforms-designer repo I found another bug in Swix package
I am talking with that team to get this sorted before I can merge this change. |
src/Microsoft.DotNet.Arcade.Sdk/tools/VisualStudio.InsertionManifests.targets
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Arcade.Sdk/tools/VisualStudio.SetupPackage.vsmanproj
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Arcade.Sdk/tools/VisualStudio.SetupPackage.vsmanproj
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Arcade.Sdk/tools/VisualStudio.SetupPackage.vsmanproj
Outdated
Show resolved
Hide resolved
mmitche
left a comment
There was a problem hiding this comment.
A few questions about nuget configuration and parallelism.
|
Discussed that we need one SBOM per VSIX, its a small change.. Will update the code and have the test on this. |
src/Microsoft.DotNet.Arcade.Sdk/tools/VisualStudio.SetupPackage.vsmanproj
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Arcade.Sdk/tools/VisualStudio.SetupPackage.vsmanproj
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Arcade.Sdk/tools/VisualStudio.InsertionManifests.targets
Outdated
Show resolved
Hide resolved
mmitche
left a comment
There was a problem hiding this comment.
Looks good so far. I'd just like to see the removal of dependence on the AzDO properties.
|
Test build VSUnitTesting repo => https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6129271&view=results |
|
WOOP WOOP! Yes! |
To double check:
Tests
Winforms-designer ->