Cherry-pick: Enable authenticated discovery of dotnet runtime packages (#8667)#8686
Merged
chcosta merged 1 commit intodotnet:release/6.0from Apr 6, 2022
Merged
Conversation
* Enable authenticated discovery of dotnet runtime packages * PR feedback: code cleanup
dougbu
reviewed
Mar 28, 2022
Contributor
dougbu
left a comment
There was a problem hiding this comment.
I am not the right person to approve a servicing change in this repo but have a few curiosity questions…
...crosoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/FindDotNetCliPackageTests.cs
Show resolved
Hide resolved
...crosoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/FindDotNetCliPackageTests.cs
Show resolved
Hide resolved
Member
Author
|
thanks for the feedback @dougbu. This is just porting the change to release/6.0. I'm not planning to address any functional issues unless they're major issues or blocking. Looks like i have a test failure, I'll take a look at that. |
mmitche
reviewed
Mar 28, 2022
mmitche
reviewed
Mar 28, 2022
Member
Author
|
The tests are failing for reasons unrelated to this PR (AFAICT). |
Member
Author
|
tests are now passing |
Member
Author
|
@mmitche can you approve this cherry-pick? Pending any further questions / comments of course. |
mmitche
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable authenticated discovery of dotnet runtime packages
PR feedback: code cleanup
To double check:
Cherry-pick #8667