Cause build warnings when sending to impending-removal Helix queues (release/6.0)#8581
Merged
MattGal merged 1 commit intodotnet:release/6.0from Mar 9, 2022
Merged
Conversation
…elease branches can get similar warnings
markwilkie
approved these changes
Mar 9, 2022
mmitche
reviewed
Mar 9, 2022
mmitche
reviewed
Mar 9, 2022
mmitche
approved these changes
Mar 9, 2022
Member
mmitche
left a comment
There was a problem hiding this comment.
No major concerns, just a couple questions
Member
Author
|
The timeouts here are not related to the changes, going to merge to prevent spinning more test runs unnecessarily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on from https://github.com/dotnet/core-eng/issues/15080 . This version of the fix wouldn't actually cause a warning if verbosity was set low enough, and most actual users of the Arcade Helix SDK set their verbosity low.
To double check:
Description
We now need to remove Helix test queues on a faster cadence when the OSes life cycle expires. This change brings a warning into builds that send to Helix if the queue is scheduled to be removed in the next 10 days with some guidance, so that users have a chance to remove usage or update to a different queue.
Customer Impact
Without this change, Helix consumers won't know about the deprecation of their queues (except from various dncpartners emails weeks before hand) until they are gone.
Regression
No
Risk
Very low: Tested in this PR validation.
Workarounds
None: The alternative is to just react when things are already broken