Skip to content

Add guidance for sbom generation through arcade templates#8450

Merged
6 commits merged intomainfrom
unknown repository
Feb 14, 2022
Merged

Add guidance for sbom generation through arcade templates#8450
6 commits merged intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 9, 2022

https://github.com/dotnet/core-eng/issues/15480

To double check:

@ghost ghost requested review from Chrisboh, epananth and mmitche February 9, 2022 19:53
@ghost ghost force-pushed the riarenas/add-sbom-generation-doc branch from 00b2ea1 to 96838a5 Compare February 9, 2022 19:53
mmitche
mmitche previously approved these changes Feb 9, 2022
Copy link
Copy Markdown
Member

@mmitche mmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor issues but overall looks g2g

@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 9, 2022

I know this is automated but:

riarenas dismissed mmitche’s stale review via 960ff59 1 minute ago

I did no such thing.

@mmitche
Copy link
Copy Markdown
Member

mmitche commented Feb 9, 2022

I know this is automated but:

riarenas dismissed mmitche’s stale review via 960ff59 1 minute ago

I did no such thing.

It's the new push that does it.

@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 9, 2022

Yep, I just don't appreciate the wording 😄

@markwilkie
Copy link
Copy Markdown
Member

Yea, the wording is weird. It should have said that "riarenas was dismissive of mmitche's old and irrelevant review"

@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 9, 2022

That does sound more like me. If GitHub is going to impersonate me it should do a better job.

@ghost ghost force-pushed the riarenas/add-sbom-generation-doc branch from 3f1e9ec to f5fec24 Compare February 11, 2022 15:54
@ghost ghost marked this pull request as ready for review February 11, 2022 16:00
@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 11, 2022

Updated with the links, values and an example image now that the template was checked in. PTAL

@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 14, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost merged commit 6d97726 into dotnet:main Feb 14, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants