Skip to content

Don't evaluate outer build targets in inner build#8434

Merged
ViktorHofer merged 3 commits intomainfrom
ViktorHofer-patch-1
Feb 4, 2022
Merged

Don't evaluate outer build targets in inner build#8434
ViktorHofer merged 3 commits intomainfrom
ViktorHofer-patch-1

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Feb 4, 2022

This is a nit change but it showed up in an msbuild binlog and hence I felt like cleaning this up, now that we already split between inner and outer build via nuget conventions.

This change has minor, probably not noticeable performance improvements. I would expect that this saves less than a second in the evaluation of an allconfigurations libraries build. Still it felt right to clean this up by doing the following:

  • BinPlace.targets isn't evaluated in outer builds
  • Two outer build targets aren't evaluated in inner builds.

These are the information messages that were logged before:

The target "DispatchToInnerBuilds" listed in a BeforeTargets attribute at "C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.targetframework\7.0.0-beta.22102.1\build\Microsoft.DotNet.Build.Tasks.TargetFramework.targets (9,11)" does not exist in the project, and will be ignored.
The target "GetTargetFrameworksWithPlatformFromInnerBuilds" listed in a BeforeTargets attribute at "C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.targetframework\7.0.0-beta.22102.1\build\Microsoft.DotNet.Build.Tasks.TargetFramework.targets (20,11)" does not exist in the project, and will be ignored.
The target "DispatchToInnerBuilds" listed in an AfterTargets attribute at "C:\Users\vihofer\.nuget\packages\microsoft.dotnet.build.tasks.targetframework\7.0.0-beta.22102.1\build\Microsoft.DotNet.Build.Tasks.TargetFramework.targets (21,11)" does not exist in the project, and will be ignored.

@ViktorHofer
Don't evaluate outer build targets in inner build
55f54f7 
This is a nit change but it showed up in an msbuild binlog and hence I felt like cleaning this up, now that we already split between inner and outer build via nuget conventions.
@ViktorHofer ViktorHofer requested review from ericstj and safern February 4, 2022 10:32
@ViktorHofer ViktorHofer self-assigned this Feb 4, 2022
@ViktorHofer ViktorHofer enabled auto-merge (squash) February 4, 2022 18:01
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Feb 4, 2022

/azp run arcade-ci

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 4, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer ViktorHofer merged commit 1791916 into main Feb 4, 2022
@safern safern deleted the ViktorHofer-patch-1 branch February 4, 2022 18:11
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@safern safern safern approved these changes

@ericstj ericstj Awaiting requested review from ericstj

Assignees

@ViktorHofer ViktorHofer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ViktorHofer @safern