Skip to content

Add publishing for .net 7 previews 1 - 3#8343

Merged
2 commits merged intomainfrom
unknown repository
Jan 13, 2022
Merged

Add publishing for .net 7 previews 1 - 3#8343
2 commits merged intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 13, 2022

#8319

To double check:

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 13, 2022

Let me know if there's something I'm missing! I'm not sure I'm up to date with all the latest changes to this space.

michellemcdaniel
michellemcdaniel approved these changes Jan 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@michellemcdaniel michellemcdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

@mmitche
Copy link
Copy Markdown
Member

mmitche commented Jan 13, 2022

You all are wonderful. Thanks for handling this.

You also need the SDK channels too though. We use separate channels for runtime and sdk.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 13, 2022 •
edited by ghost
Loading

I knew that... derp. Do we want them the same way we had them for .net 6? ie .NET 7.0.1xx SDK Preview 1-3?

@mmitche
Copy link
Copy Markdown
Member

mmitche commented Jan 13, 2022

I knew that... derp. Do we want them the same way we had them for .net 6? ie .NET 7.0.1xx SDK Preview 1-3?

Yep same format

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 13, 2022

@adiaaida can you take another look? Tried to follow the existing patterns for the aka.ms channels for the current sdk channel, but not sure if those lists are right.

michellemcdaniel
michellemcdaniel approved these changes Jan 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@michellemcdaniel michellemcdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good. That's what I'd expect to see

@ghost ghost merged commit ecf92bb into dotnet:main Jan 13, 2022
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexperovich alexperovich Awaiting requested review from alexperovich

@epananth epananth Awaiting requested review from epananth

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmitche @michellemcdaniel