MSI Bundle generator should honor msbuild Authors property when setting the authors value of the resulting msi file.#8275
Merged
NikolaMilosavljevic merged 1 commit intodotnet:mainfrom Jan 14, 2022
AraHaan:patch-1
Merged
MSI Bundle generator should honor msbuild Authors property when setting the authors value of the resulting msi file.#8275NikolaMilosavljevic merged 1 commit intodotnet:mainfrom AraHaan:patch-1
NikolaMilosavljevic merged 1 commit intodotnet:mainfrom
AraHaan:patch-1
Conversation
Member
Author
|
Just rebased on top of current main, hopefully after this the CI would ignore that strange failure and just work. |
joeloff
reviewed
Dec 20, 2021
src/Microsoft.DotNet.Build.Tasks.Installers/build/wix/variables.wxi
Outdated
Show resolved
Hide resolved
joeloff
reviewed
Dec 20, 2021
src/Microsoft.DotNet.Build.Tasks.Installers/build/wix/wix.targets
Outdated
Show resolved
Hide resolved
Member
Author
|
I have squashed to a single commit on my computer after making the changes on web. |
src/Microsoft.DotNet.Build.Tasks.Installers/build/wix/variables.wxi
Outdated
Show resolved
Hide resolved
Member
Author
|
@joeloff, @NikolaMilosavljevic is this LGTM? |
src/Microsoft.DotNet.Build.Tasks.Installers/build/wix/wix.targets
Outdated
Show resolved
Hide resolved
Member
Author
|
This should be ready now. Sorry for the wait. |
…ng the authors value of the resulting msi file. Fixes #8260.
NikolaMilosavljevic
approved these changes
Jan 13, 2022
Member
Approved. |
Member
Author
|
Is this ready to be merged yet? |
Member
Just merged it now. Thanks for doing this! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8260.
To double check:
Note: I tested this change manually with an msi and exe bundle and it works for both.