Fix xliff tasks being loaded even when not needed#8244
Merged
bekir-ozturk merged 1 commit intomainfrom Dec 6, 2021
Merged
Conversation
MattGal
approved these changes
Dec 6, 2021
Member
MattGal
left a comment
There was a problem hiding this comment.
This seems fine, but do note that the setting is opt-out (true by default) if that matters.
Member
|
Ready to merge? It would be good to get aspnetcore and ef dependency updates unblocked. |
Contributor
Author
|
The issue is now fixed and the dependency update was merged into aspnetcore repo. |
Member
|
We are seeing the xliff failures in our repo with the latest arcade update PR - https://github.com/dotnet/upgrade-assistant/pull/970/checks?check_run_id=4464498289. Assuming the next arcade update should have the fix? @dotnet/dnceng |
|
Yes. the next update will have this fix. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue created by #8233
After the change above, Xliff tasks package is now loaded even in the cases where it isn't needed.
This causes issues with some repos (and likely others that aren't listed below):
The dotnet/templating and dotnet/test-templates repos seem to be working fine and are not affected by this bug.
The fix is to correct the usage of flags so that Xliff tasks package will only be loaded when needed.
Tested on local clone of winforms repo. Xliff tasks are no longer referenced unless needed.
To double check: