Fix aka.ms links when no ChannelNames given#8236
Merged
michellemcdaniel merged 1 commit intodotnet:mainfrom Dec 2, 2021
Merged
Fix aka.ms links when no ChannelNames given#8236michellemcdaniel merged 1 commit intodotnet:mainfrom
michellemcdaniel merged 1 commit intodotnet:mainfrom
Conversation
When there are no AkaMSChannelNames, we used to default to using dotnet/ as the short link url. When we switched to multiple possible channel names, we removed that default, so any channel with nothing in the list would just not create aka.ms links. This change returns to the previous behavior to use the default dotnet/ short link url.
2 tasks
riarenas
approved these changes
Dec 2, 2021
alexperovich
approved these changes
Dec 2, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are no AkaMSChannelNames, we used to default to using dotnet/ as the short link url. When we switched to multiple possible channel names, we removed that default, so any channel with nothing in the list would just not create aka.ms links. This change returns to the previous behavior to use the default dotnet/ short link url.
To double check: