Set skip-non-versioned-files#8208
Conversation
| architecture=$3 | ||
| fi | ||
| InstallDotNet "$root" "$version" $architecture 'sdk' 'false' $runtime_source_feed $runtime_source_feed_key | ||
| InstallDotNet "$root" "$version" $architecture 'sdk' 'true' $runtime_source_feed $runtime_source_feed_key |
There was a problem hiding this comment.
Don't we need at least one caller to install dotnet? I was imagining that the SDK would install it but runtimes would not. Looks to me like the default is already true here:
arcade/eng/common/dotnet-install.sh
Line 78 in 977c461
I wonder why the SDK ends up overwriting? cc @joeloff
There was a problem hiding this comment.
It looks like the SDK might have it's own copy of some similar logic 😮
There was a problem hiding this comment.
I asked around, but nobody knows. It was before I joined the SDK, but no one recalls any specific reason (I assume you're referring to the host getting overwritten and causing problems on OSx)
There was a problem hiding this comment.
It was set to true in one place, and this one was false. I made them both true. It will install if it doesn't exist so this change just means the first sdk installed will produce the dotnet host exe.
To double check: