Use the source directory as the working directory for running sdl#8167
Merged
michellemcdaniel merged 1 commit intodotnet:mainfrom Nov 10, 2021
Merged
Use the source directory as the working directory for running sdl#8167michellemcdaniel merged 1 commit intodotnet:mainfrom
michellemcdaniel merged 1 commit intodotnet:mainfrom
Conversation
We were using the "working directory," which is one level up from the SourceDirectory passed in. This meant that we were unintentionally getting the .gdn directory and anything else that may be laying around on the machine as part of our working directory. In the Validate-DotNet pipeline, it meant we were scanning more than we were meaning to scan. This change adjusts our call to run-sdl to use the SourceDirectory (ie what we actually WANT to scan) as the working directory.
epananth
approved these changes
Nov 10, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using the "working directory," which is one level up from the SourceDirectory passed in. This meant that we were unintentionally getting the .gdn directory and anything else that may be laying around on the machine as part of our working directory. In the Validate-DotNet pipeline, it meant we were scanning more than we were meaning to scan.
This change adjusts our call to run-sdl to use the SourceDirectory (ie what we actually WANT to scan) as the working directory.
To double check: