Switch source-build yamls to 1ES hosted pools#8131
Conversation
|
Have you tried this in an internal build to make sure all the YAML ends up correct? |
riarenas
left a comment
There was a problem hiding this comment.
LGTM with a question about changing from ubuntu 20.04 to 18.04, and I'd suggest trying an internal build of this branch just to make sure you don't get bitten by YAML.
| # source-build builds run in Docker, including the default managed platform. | ||
| defaultContainerHostPool: | ||
| vmImage: ubuntu-20.04 | ||
| ${{ if eq(variables['System.TeamProject'], 'public') }}: |
There was a problem hiding this comment.
We will probably need to have 2 parameters on that template? For internal and public pool?
Which will probably break someone down the line?
There was a problem hiding this comment.
FWIW, I learned recently about the parameter types in AzDO pipelines and these are the allowed types:
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/templates?view=azure-devops#parameter-data-types
There was a problem hiding this comment.
Yeah, looks like I have to split it into two parameters. I'm not sure who is using it and how so I don't know what will be the impact of this. The name suggests that it may be just some fallback when no other pool is specified.
Does anyone know who may be familiar with this code?
There was a problem hiding this comment.
Potentially someone from the acquisition team?
There was a problem hiding this comment.
I don't see this parameter being specified in any repos usage of the template. I am guessing here, but I think this parameter could have possibly been defined as a convenient place to define the default value. I think the best approach is to remove the parameter and define the condition in the single place it is referenced.
There was a problem hiding this comment.
Ok, I did exactly that.
I also had to do the same change in source-index-stage1.yml.
|
I had to switch windows images to |
MichaelSimons
left a comment
There was a problem hiding this comment.
The change so the source-build job template LGTM.
This is a follow-up on the previous PR: #8108. This one adds conditionals to make it work both on public and internal projects.
Tracking issue: #7786