Update version file template based on feedback in dotnet/runtime#58674#7872
Conversation
|
Is this just a fallback, or is this going to be used in the shipping binaries from Microsoft official builds? |
|
This would be the shipping version info. Based on your question, do we want to keep the shipping info the same as it has always been? If so, I'd like to keep the fallback matching this one as the fallback will only be used on bringup platforms or weirdly built local builds. |
|
We have overrides of these defaults in some places already. For example, coreclr.dll from .NET 6 P7 has product name I would change The rest would be larger effort to cleanup. We do not seem to be setup to have proper company-specific labeling on binaries, and cleaning that up would be larger effort. So ignore it for now. |
|
Can you take a look at the updated diff and let me know if that looks good? |
To double check:
cc: @jkotas