Merged
Conversation
Contributor
|
do you think there will be cases where we may not want to suppress it ? |
Author
Never in *typeforwards.cs I think. |
jeffhandley
approved these changes
Sep 7, 2021
Member
jeffhandley
left a comment
There was a problem hiding this comment.
LGTM but I'd like to get a review from one of the libraries infrastructure folks too.
Anipik
approved these changes
Sep 8, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was building dotnet/runtime locally to test CA2252 and ran into some warnings generated from System.Runtime.Forwards.cs and System.Runtime.Intrinsics.Forwards.cs. In either case, the type forwarded to attribute references preview types, so CA2252 is triggered. I think the only thing to do here is to suppress the warnings during the build.
I considered adding a new property to the csproj, but the change here is so small that I don't think it's worth it.
cc @jeffhandley