Fix installation for library and template packs#7651
Merged
joeloff merged 4 commits intodotnet:mainfrom Jul 22, 2021
Merged
Conversation
Member
|
The only other thing I can think of here is related to dotnet/sdk#17438. The template packs we produce and publish are camel-cased, however |
Member
Author
|
camel casing won't impact the MSIs, but we do use the package IDs when creating folders. More importantly, the IDs participate in generating some of the GUIDs. For the most part its fine, except in the case of manifests where the MSIs have to be upgradable, so any change in casing could break that. |
pjcollins
reviewed
Jul 22, 2021
pjcollins
approved these changes
Jul 22, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that library and template packs install directly under the root folder, e.g. dotnet\library-packs (no versioned sub-folders)