Skip to content

Include Dependency Frameworks in set of TFMs considered for package testing#7645

Merged
Anipik merged 2 commits intodotnet:mainfrom
ericstj:validateMetaPackages
Jul 20, 2021
Merged

Include Dependency Frameworks in set of TFMs considered for package testing#7645
Anipik merged 2 commits intodotnet:mainfrom
ericstj:validateMetaPackages

Conversation

@ericstj
Copy link
Member

@ericstj ericstj commented Jul 19, 2021

Fixes dotnet/runtime#27503

I believe this should fix testing for meta-packages as it will consider Frameworks for testing if they are used in dependency groups (not just files).

I haven't been able to try this out in dotnet/runtime yet and would want to do so before merging.

@ericstj ericstj requested review from Anipik, ViktorHofer and safern July 19, 2021 21:23
@ericstj
Copy link
Member Author

ericstj commented Jul 19, 2021

Tested locally and this does catch the windows compat bug:

C:\src\dotnet\runtime\artifacts\bin\testPackages\projects\Microsoft.Windows.Compatibility\project.csproj : error NU1603: Microsoft.Windows.Compatibility 6.0.0-dev depends on System.Data.SqlClient (>= 4.8.2-dev) but System.Data.SqlClient 4.8.2-dev was not found. An approximate best match of System.Data.SqlClient 4.8.2 was resolved. [C:\src\dotnet\runtime\artifacts\bin\testPackages\dirs.proj]

Also found a new failure:

C:\src\dotnet\runtime\artifacts\bin\testPackages\projects\Microsoft.Windows.Compatibility\project.csproj : error NU1603: runtime.native.System.IO.Ports 6.0.0-dev depends on runtime.linux-arm.runtime.native.System.IO.Ports (>= 6.0.0-dev) but runtime.linux-arm.runtime.native.System.IO.Ports 6.0.0-dev was not found. An approximate best match of runtime.linux-arm.runtime.native.System.IO.Ports 6.0.0-preview.1.21071.15 was resolved. [C:\src\dotnet\runtime\artifacts\bin\testPackages\dirs.proj]
C:\src\dotnet\runtime\artifacts\bin\testPackages\projects\Microsoft.Windows.Compatibility\project.csproj : error NU1603: runtime.native.System.IO.Ports 6.0.0-dev depends on runtime.linux-arm64.runtime.native.System.IO.Ports (>= 6.0.0-dev) but runtime.linux-arm64.runtime.native.System.IO.Ports 6.0.0-dev was not found. An approximate best match of runtime.linux-arm64.runtime.native.System.IO.Ports 6.0.0-preview.1.21071.15 was resolved. [C:\src\dotnet\runtime\artifacts\bin\testPackages\dirs.proj]
C:\src\dotnet\runtime\artifacts\bin\testPackages\projects\Microsoft.Windows.Compatibility\project.csproj : error NU1603: runtime.native.System.IO.Ports 6.0.0-dev depends on runtime.linux-x64.runtime.native.System.IO.Ports (>= 6.0.0-dev) but runtime.linux-x64.runtime.native.System.IO.Ports 6.0.0-dev was not found. An approximate best match of runtime.linux-x64.runtime.native.System.IO.Ports 6.0.0-preview.1.21071.15 was resolved. [C:\src\dotnet\runtime\artifacts\bin\testPackages\dirs.proj]
C:\src\dotnet\runtime\artifacts\bin\testPackages\projects\Microsoft.Windows.Compatibility\project.csproj : error NU1603: runtime.native.System.IO.Ports 6.0.0-dev depends on runtime.osx-x64.runtime.native.System.IO.Ports (>= 6.0.0-dev) but runtime.osx-x64.runtime.native.System.IO.Ports 6.0.0-dev was not found. An approximate best match of runtime.osx-x64.runtime.native.System.IO.Ports 6.0.0-preview.1.21071.15 was resolved. [C:\src\dotnet\runtime\artifacts\bin\testPackages\dirs.proj]

Here we'll just need to disable that project since it's expected that a single build isn't producing all these packages.

Anipik
Anipik approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@Anipik Anipik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need a test in place.

safern
safern approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ericstj ericstj mentioned this pull request Jul 20, 2021
Merged
@Anipik Anipik merged commit d314438 into dotnet:main Jul 20, 2021
@ericstj
Copy link
Member Author

ericstj commented Jul 20, 2021

Thanks @Anipik. I merged dotnet/runtime#55976 so we should be ready to accept this change. It's still possible that new failures are introduced. @missymessa let us know if you see any dotnet/runtime failures around package testing during arcade ingestion.

@akoeplinger akoeplinger mentioned this pull request Jul 21, 2021
Merged
ViktorHofer
ViktorHofer reviewed Jul 22, 2021
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

@safern safern safern approved these changes

+1 more reviewer

@Anipik Anipik Anipik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package testing skips Microsoft.Windows.Compatibility

4 participants

@ericstj @ViktorHofer @Anipik @safern