Merged
Conversation
1 task
michellemcdaniel
approved these changes
Jul 19, 2021
Contributor
michellemcdaniel
left a comment
There was a problem hiding this comment.
I'm happy with this, but make sure Chris gets a chance to review
Member
Author
|
@chcosta can you please take a look at this before I merge this change? |
chcosta
requested changes
Jul 19, 2021
chcosta
reviewed
Jul 20, 2021
chcosta
approved these changes
Jul 20, 2021
Member
chcosta
left a comment
There was a problem hiding this comment.
Remove the "true" explicit check and this LGTM
|
Hello @epananth! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
1 task
3 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check:
Added ability to turn off telemetry in Telemetry.cs
was able to test this in release pipeline -> https://dnceng.visualstudio.com/internal/_build/results?buildId=1241503&view=logs&j=d7f318d2-3658-5f56-29df-16b211ec56a6&t=7851342b-b7f6-561e-0dbe-e63708dfa83e